Review Request 123883: DolphinSearchBox: Add a "More search tools..." menu button

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123883/#review80935
-----------------------------------------------------------



src/search/dolphinsearchbox.cpp (line 389)
<https://git.reviewboard.kde.org/r/123883/#comment55453>

    Please remove the lazy loading from here, makes the code harder to read than necessary.
    
    If you want lazy loading of items (which makes sense :), then please add it to KMoreTools.
    
    The menu factory could create a specialized QMenu object which loads and inserts the items on the first show event - so all the users of KMoreTools can make use of it and we have a nicer client-side code base :)
    
    class LazyMenu : QMenu {
      onshow {
         if (firstShow) load tools and add them to the menu
      }
    
    KMoreToolsMenuFactory {
       QMenu createMenuFromGroupingNames {
           return new LazyMenu
       }
    }


- Emmanuel Pescosta


On May 23, 2015, 5:57 p.m., Gregor Mi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123883/
> -----------------------------------------------------------
> 
> (Updated May 23, 2015, 5:57 p.m.)
> 
> 
> Review request for Dolphin and Emmanuel Pescosta.
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> This is the prototype of a "More search tools..." button added to the DolphinSearchBox.
> 
> Additionally, this moves the "More/Fewer options" button from right to left to reduce the mouse travelling distance when the dolphin is maximized on a large screen. Of course, if this violates a higher design goal which I maybe don't know yet, I'll remove this part from the RR.
> 
> In a LATER step the following could be done:
> - The current location url could be passed to the search tool to set the search root directory.
> 
> 
> Diffs
> -----
> 
>   src/search/dolphinsearchbox.cpp 743d9113a9ae0f7820d1bed594462a208b2883c3 
> 
> Diff: https://git.reviewboard.kde.org/r/123883/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> Currently there is a long mouse traveling distance
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/05/23/8d717a70-215d-4587-89d0-2fee89263731__MoreOptionsTravellingDistance.png
> "More search tools" and the "More/fewer options" buttons moved more to the left
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/05/23/3009c4e7-5666-4377-bf39-5ec1967858e6__MoreSearchTools.png
> 
> 
> Thanks,
> 
> Gregor Mi
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20150528/cd012e7e/attachment.htm>