Review Request 123851: dolphin filter: add RE support

Vishesh Handa me at vhanda.in
Tue May 19 11:17:33 BST 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123851/#review80618
-----------------------------------------------------------


On a slightly tangential note, we probably want to move to QRegularExpression. It's much faster.

Source - https://dangelog.wordpress.com/2012/04/07/qregularexpression/


src/kitemviews/private/kfileitemmodelfilter.cpp (line 55)
<https://git.reviewboard.kde.org/r/123851/#comment55274>

    Please fix the coding style. You need to put a space after the comma.


- Vishesh Handa


On May 19, 2015, 9 a.m., Vladimir Perepechin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123851/
> -----------------------------------------------------------
> 
> (Updated May 19, 2015, 9 a.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> Allow to use regular expressions in filter bar for dolphin
> 
> 
> Diffs
> -----
> 
>   src/kitemviews/private/kfileitemmodelfilter.cpp 6c6f94f 
> 
> Diff: https://git.reviewboard.kde.org/r/123851/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vladimir Perepechin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20150519/ebef4fa5/attachment.htm>


More information about the kfm-devel mailing list