[KDE Usability] Review Request 123658: If double-click is on empty area, then invoke back.

[Frank Reininghaus]

> On Mai 6, 2015, 10:31 vorm., Ashish Bansal wrote:
> > Sometimes when double click is done on the directories, it goes into that directory and comes back. That's because of some other bug due to which "-1" index is passed, although index should not be -1 if there is successful click on some directory.

Maybe this is because the first click of a "double-click" on a folder makes Dolphin enter the directory, and only after the second click the "double-click" is recognized as such, such that the new code "if (index == -1)" is executed in the context of the new folder?

I don't have an opinion on whether the proposed feature is desirable or not, but such problems must be fixed before the feature is added IMHO. (I don't see an easy way to fix that at the moment though, and I'm not sure if the feature is so important that adding complex code for working around this issue makes sense.)


- Frank


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123658/#review79948
-----------------------------------------------------------


On Mai 6, 2015, 7:41 nachm., Ashish Bansal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123658/
> -----------------------------------------------------------
> 
> (Updated Mai 6, 2015, 7:41 nachm.)
> 
> 
> Review request for Dolphin, KDE Usability and Emmanuel Pescosta.
> 
> 
> Bugs: 307505
>     https://bugs.kde.org/show_bug.cgi?id=307505
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> If mouse double click is done on the empty area, then invoke the go back to previous directory in the history.
> 
> 
> Diffs
> -----
> 
>   src/kitemviews/kitemlistcontroller.h b8a93ed 
>   src/kitemviews/kitemlistcontroller.cpp 1c86ff0 
>   src/views/dolphinview.cpp d302358 
> 
> Diff: https://git.reviewboard.kde.org/r/123658/diff/
> 
> 
> Testing
> -------
> 
> Doesn't works sometimes.
> 
> 
> Thanks,
> 
> Ashish Bansal
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20150510/0c84e669/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-usability mailing list
kde-usability at kde.org
https://mail.kde.org/mailman/listinfo/kde-usability