Review Request 123643: Move away from Baloo::Term

Vishesh Handa me at vhanda.in
Fri May 8 15:18:31 BST 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123643/
-----------------------------------------------------------

(Updated May 8, 2015, 2:18 p.m.)


Review request for Dolphin.


Changes
-------

Made some changes.

DolphinFacetWidget::isRatingTerm -> We just check if one of the terms is either 'modified' or 'rating'.


Repository: dolphin


Description
-------

Baloo is set to become a framework and wants to only export the bare
    minimum number of classes as it will need to provide ABI + API
    guarentees forever. The Term class is now no longer exported. It can be
    added back again.


Diffs (updated)
-----

  src/search/dolphinfacetswidget.h 03fb127 
  src/search/dolphinfacetswidget.cpp b183eb8 
  src/search/dolphinsearchbox.cpp b67d1e6 

Diff: https://git.reviewboard.kde.org/r/123643/diff/


Testing
-------

Searching seems to work.


Thanks,

Vishesh Handa

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20150508/6c2015b8/attachment.htm>


More information about the kfm-devel mailing list