Review Request 123643: Move away from Baloo::Term

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123643/#review79973
-----------------------------------------------------------



src/search/dolphinfacetswidget.cpp (line 172)
<https://git.reviewboard.kde.org/r/123643/#comment54857>

    makes the else if unreachable, so better use size == 1 ;)



src/search/dolphinsearchbox.cpp (line 492)
<https://git.reviewboard.kde.org/r/123643/#comment54856>

    This will split too much I guess.
    
    e.g. search string is "text rating AND modified" -> splits the rating term
    
    so you will need different separators for each level
    
    e.g. "text&rating%modified"
    
    A better we to fix it:
    Maybe we should add the following methods to the facet widget and use
    them in the search box to build/parse the actual query and remove
    the isRatingTerm, ratingTerm and setRatingTerm:
    
    setRating(int) + int rating()
    setModified(QDate) + QDate modified()
    
    So we don't spread the query building/parsing over multiple places and
    it's the same as the filename term handling :)


- Emmanuel Pescosta


On May 6, 2015, 3:01 p.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123643/
> -----------------------------------------------------------
> 
> (Updated May 6, 2015, 3:01 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> Baloo is set to become a framework and wants to only export the bare
>     minimum number of classes as it will need to provide ABI + API
>     guarentees forever. The Term class is now no longer exported. It can be
>     added back again.
> 
> 
> Diffs
> -----
> 
>   src/search/dolphinfacetswidget.h 03fb127 
>   src/search/dolphinfacetswidget.cpp b183eb8 
>   src/search/dolphinsearchbox.cpp b67d1e6 
> 
> Diff: https://git.reviewboard.kde.org/r/123643/diff/
> 
> 
> Testing
> -------
> 
> Searching seems to work.
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20150506/67fd5423/attachment.htm>