Review Request 122911: dolphin: SpaceInfoToolsMenu: introduce KMoreTools

Gregor Mi codestruct at posteo.org
Sat May 2 22:51:24 BST 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122911/
-----------------------------------------------------------

(Updated May 2, 2015, 9:51 p.m.)


Review request for Dolphin and Emmanuel Pescosta.


Changes
-------

Reduce amount of code by using first version of the new class KMoreToolsMenuFactory.


Repository: dolphin


Description
-------

Moved from old dolphin repo (kde-baseapps, https://git.reviewboard.kde.org/r/122352/)


Diffs (updated)
-----

  src/CMakeLists.txt 560545aed687c081fef50cf9fa5afa212ee0fb18 
  src/statusbar/spaceinfotoolsmenu.h 3ca2e184f03b31d10d661c5a931644485ffc46e6 
  src/statusbar/spaceinfotoolsmenu.cpp 40ca56e19ebec33518bae0c94dcb56318b473290 
  src/statusbar/statusbarspaceinfo.cpp 127641e601d1468479ef925f9539ecd31dc12fb7 

Diff: https://git.reviewboard.kde.org/r/122911/diff/


Testing
-------


File Attachments
----------------

less entries by default than before
  https://git.reviewboard.kde.org/media/uploaded/files/2015/04/10/77cb7101-49ae-4812-9958-373cc3961a73__less_entries_by_default_than_before.png
more entries in submenu
  https://git.reviewboard.kde.org/media/uploaded/files/2015/04/10/64a2f205-2db1-4f39-a252-74832f8bb196__more_entries_in_submenu.png
configure menu dialog
  https://git.reviewboard.kde.org/media/uploaded/files/2015/04/10/e0a46310-7090-4d95-a0c9-198d5783a5eb__configure_menu_dialog.png


Thanks,

Gregor Mi

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20150502/1e26d06d/attachment.htm>


More information about the kfm-devel mailing list