Review Request 123137: High DPI pixmap support in Dolphin

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123137/#review78074
-----------------------------------------------------------



src/kitemviews/kfileitemlistview.cpp (line 159)
<https://git.reviewboard.kde.org/r/123137/#comment53494>

    const



src/kitemviews/kstandarditemlistwidget.cpp (line 959)
<https://git.reviewboard.kde.org/r/123137/#comment53498>

    remove?



src/kitemviews/kstandarditemlistwidget.cpp (line 961)
<https://git.reviewboard.kde.org/r/123137/#comment53499>

    use the dpr from the pixmap?



src/kitemviews/kstandarditemlistwidget.cpp (line 1360)
<https://git.reviewboard.kde.org/r/123137/#comment53500>

    dpr from pixmap?



src/kitemviews/kstandarditemlistwidget.cpp (line 1444)
<https://git.reviewboard.kde.org/r/123137/#comment53501>

    Remove this and use requestedSize * dpr instead?!
    
    Because this approach will lead to different requestedSize <-> size proportions for different dpr values.



src/kitemviews/private/kpixmapmodifier.h (lines 33 - 51)
<https://git.reviewboard.kde.org/r/123137/#comment53495>

    What if we use the dpr from the given pixmap and let the size be unscaled?



src/kitemviews/private/kpixmapmodifier.cpp (line 368)
<https://git.reviewboard.kde.org/r/123137/#comment53497>

    const



src/kitemviews/private/kpixmapmodifier.cpp (line 377)
<https://git.reviewboard.kde.org/r/123137/#comment53496>

    const


- Emmanuel Pescosta


On March 26, 2015, 4:51 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123137/
> -----------------------------------------------------------
> 
> (Updated March 26, 2015, 4:51 p.m.)
> 
> 
> Review request for Dolphin, Christoph Feck and Marco Martin.
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> Quite a lot of changes, Dolphin does a /lot/ of special pixmap caching and manipulating.
> 
> Changes are in branch davidedmundson/highdpi
> 
> ----
> 
> 
> Make KPixmapModifier::applyFrame handle high DPI images
> 
> 
> Paint icons at the correct size
> 
> 
> squash me with a some other commit in kitemlistwidgetinformant
> 
> 
> Copy device pixel ratio from original pixmap inside KPixmapModifier::scale
> 
> 
> Create drag pixmaps which match the device pixel ratio
> 
> 
> Provide scaled pixmaps in the main file model
> 
> 
> Enable high DPI pixmaps in Dolphin
> 
> 
> Center align pixmaps in a high DPR friendly way
> 
> 
> Diffs
> -----
> 
>   src/kitemviews/kfileitemlistview.cpp d249bef 
>   src/kitemviews/kfileitemmodelrolesupdater.cpp c18d658 
>   src/kitemviews/kitemlistcontroller.cpp a9ebf97 
>   src/kitemviews/kitemlistwidget.cpp 3eb6b1d 
>   src/kitemviews/kstandarditemlistwidget.h 8264522 
>   src/kitemviews/kstandarditemlistwidget.cpp f663b87 
>   src/kitemviews/private/kpixmapmodifier.h e8ca11a 
>   src/kitemviews/private/kpixmapmodifier.cpp c564ecc 
>   src/main.cpp e8d6c2d 
>   src/panels/information/pixmapviewer.cpp 0053e43 
> 
> Diff: https://git.reviewboard.kde.org/r/123137/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20150326/6623e32b/attachment.htm>