Review Request 112328: Add case sensitive sorting option to KGlobalSettings and KDirSortFilterProxyModel

[Thomas Lübking]

> On Sept. 4, 2013, 2:38 nachm., Martin Gräßlin wrote:
> > KGlobalSettings moved into KDE4Support in frameworks 5. I would suggest to not add new API to an already deprecated class. Maybe you want to provide a patch for the proper way in frameworks?
> 
> Frank Reininghaus wrote:
>     Marin, could you explain what the proper way is? Thanks!

Marin? :-P

Ok, I'm neither Marin nor Martin, but lxr.kde.org reveals that
a) dolphin (now?) uses an internal setting for natural sorting anyway?
b) KDirSortFilterProxyModel reads the naturalSorting key directly (and has a degenerated "slotNaturalSortingChanged")

The only question is, what GUI should be available to configure this, what likely boils down to whether or not dolphin should move (parts of) its configuration into a kcm-filemanger or so, which would write settings that could also be read by krusader (and the open/save dialogs and whatnot)


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/112328/#review39355
-----------------------------------------------------------


On Aug. 29, 2013, 1:11 nachm., Eugene Shalygin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/112328/
> -----------------------------------------------------------
> 
> (Updated Aug. 29, 2013, 1:11 nachm.)
> 
> 
> Review request for Dolphin and kdelibs.
> 
> 
> Bugs: https://bugs.kde.org/show_bug.cgi?id=148550
>     http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=148550
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> There are number of people who want to have case sensitive sorting in file manager and file dialogs (that would be consistent with locale settings).
> 
> The proposed patch adds a property to KGlobalSettings (caseSensitiveSorting()) and the new signal sortingModeChanged(), which deprecates naturalSortingChanged(), so the clients can connect to only one event and do not resort their models twice (maybe and option for the event to pass the change reason would be useful?).
> 
> KDirSortFilterProxyModel is changed in a trivial manner to use new event and handle case sensitivity changes.
> 
> 
> Diffs
> -----
> 
>   kdeui/kernel/kglobalsettings.h 96da20e 
>   kdeui/kernel/kglobalsettings.cpp 2e3a7eb 
>   kfile/kdirsortfilterproxymodel.h 63cf04c 
>   kfile/kdirsortfilterproxymodel.cpp 34ddcd2 
> 
> Diff: https://git.reviewboard.kde.org/r/112328/diff/
> 
> 
> Testing
> -------
> 
> Manual
> 
> 
> Thanks,
> 
> Eugene Shalygin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20150621/b3f8129d/attachment.htm>