Review Request 122310: Port Dolphin away from KGlobalSettings::naturalSorting()

[Emmanuel Pescosta]

> On Jan. 30, 2015, 7:25 p.m., Christoph Feck wrote:
> > Is the diff complete? I do not see the UI changes (.ui file?)

Yes. No UI changes needed, because the checkbox for "Natural sorting" was already there ;)
I have only replaced the KGlobalSettings by GeneralSettings.


- Emmanuel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122310/#review75053
-----------------------------------------------------------


On Jan. 30, 2015, 1:10 p.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122310/
> -----------------------------------------------------------
> 
> (Updated Jan. 30, 2015, 1:10 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> Port away from KGlobalSettings::naturalSorting() by moving it to Dolphin's GeneralSettings
> 
> 
> Diffs
> -----
> 
>   dolphin/src/CMakeLists.txt d2ea493 
>   dolphin/src/kitemviews/kfileitemmodel.cpp 98249db 
>   dolphin/src/settings/dolphin_generalsettings.kcfg 3c820e2 
>   dolphin/src/settings/general/behaviorsettingspage.cpp 83515be 
>   dolphin/src/tests/CMakeLists.txt a69400b 
> 
> Diff: https://git.reviewboard.kde.org/r/122310/diff/
> 
> 
> Testing
> -------
> 
> Works
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20150130/4afeddee/attachment.htm>