Review Request 122308: Port Dolphin away from KGlobalSettings::smallestReadableFont()

[Emmanuel Pescosta]

> On Jan. 30, 2015, 7:47 a.m., Emmanuel Pescosta wrote:
> > dolphin/src/panels/information/informationpanelcontent.cpp, line 59
> > <https://git.reviewboard.kde.org/r/122308/diff/1/?file=345682#file345682line59>
> >
> >     Hmm, I just removed a K* include from the Ks and added a Q* include to the Qs. What exactly is wrong with the sorting?
> 
> Christoph Feck wrote:
>     What I meant was that it should have appeared before the QEvent include but we can resort all of them in a separate commit
> 
> Christoph Feck wrote:
>     well, *after* QEvent

> but we can resort all of them in a separate commit

This needs to be done for the whole Dolphin code base, all the porting efforts created a huge include mess ;)


- Emmanuel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122308/#review75030
-----------------------------------------------------------


On Jan. 30, 2015, 9:06 a.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122308/
> -----------------------------------------------------------
> 
> (Updated Jan. 30, 2015, 9:06 a.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> Port KGlobalSettings::smallestReadableFont() to QFontDatabase::systemFont(QFontDatabase::SmallestReadableFont)
> 
> 
> Diffs
> -----
> 
>   dolphin/src/panels/information/informationpanelcontent.cpp 4e32a79 
> 
> Diff: https://git.reviewboard.kde.org/r/122308/diff/
> 
> 
> Testing
> -------
> 
> Looks good
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20150130/acc9ec49/attachment.htm>