Review Request 122311: Port Dolphin away from KGlobalSettings::singleClick()

[Emmanuel Pescosta]

> On Jan. 30, 2015, 2:10 a.m., Christoph Feck wrote:
> > dolphin/src/settings/navigation/navigationsettingspage.cpp, line 64
> > <https://git.reviewboard.kde.org/r/122311/diff/1/?file=345695#file345695line64>
> >
> >     I would not add a button to open "kcmshell5 mouse" in Dolphin. On other platforms, the native mouse settings dialog is used to configure what the styleHint() for that platform returns.
> >     
> >     Maybe add someone from OSX or KDE/Windows group to check if there is a solution to run those native settings programs, if it simply needs to be wrapped in "if linux", or if it should not be added at all.

I removed the button.

Maybe we should move the remaining two options from Navigation to General->Behavior.


- Emmanuel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122311/#review75025
-----------------------------------------------------------


On Jan. 30, 2015, 9:20 a.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122311/
> -----------------------------------------------------------
> 
> (Updated Jan. 30, 2015, 9:20 a.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> Port away from KGlobalSettings::singleClick() and use the mouse kcm module instead of implementing the single/double click settings on our one. 
> 
> I think this solution is better than copying the code from the (more advanced) mouse kcm into Dolphin. What do you think?
> 
> 
> Diffs
> -----
> 
>   dolphin/src/kitemviews/kitemlistcontroller.h ed5b716 
>   dolphin/src/kitemviews/kitemlistcontroller.cpp 812d1c9 
>   dolphin/src/settings/navigation/navigationsettingspage.h ff1ed31 
>   dolphin/src/settings/navigation/navigationsettingspage.cpp 69feed3 
>   dolphin/src/tests/kitemlistcontrollertest.cpp cd4d0a6 
> 
> Diff: https://git.reviewboard.kde.org/r/122311/diff/
> 
> 
> Testing
> -------
> 
> Changing to single/double click activation in the Mouse KCM also changes the behaviour in Dolphin
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20150130/3a406d31/attachment.htm>