Review Request 122310: Port Dolphin away from KGlobalSettings::naturalSorting()

[Emmanuel Pescosta]

> On Jan. 30, 2015, 2:16 a.m., Christoph Feck wrote:
> > If we are the only user of that setting, why not add a checkbox in Dolphin settings pages? Looking at bugs and wishes, people need even more sorting options e.g. case sensitive (bug 148550), or locale-aware (bug 211531), so moving the settings to Dolphin seems sensible.

> If we are the only user of that setting, why not add a checkbox in Dolphin settings pages?

Ok I'll change it. Thanks for the feedback!

> or locale-aware (bug 211531)

Should be fixed in the frameworks branch of Dolphin


- Emmanuel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122310/#review75026
-----------------------------------------------------------


On Jan. 29, 2015, 5:40 p.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122310/
> -----------------------------------------------------------
> 
> (Updated Jan. 29, 2015, 5:40 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> Port away from KGlobalSettings::naturalSorting() by removing the natural-sorting option from Dolphin -> always use natural sorting
> 
> * There is no global "natural sorting" settings changed signal anymore to inform all fileitem models and all running Dolphin instances, that the natural sorting has been enabled or disabled.
> * We are the only users of the natural sorting option as far as I see
> * I have found no porting notes (I have found an email from Frank, where he raised the question how to port away from KGlobalSettings::naturalSorting(), but nobody answered so far)
> * It would be interesting to know how many Dolphin users actually disable the natural sorting ;)
> 
> Does anybody know a better solution than always using natural sorting?
> 
> 
> Diffs
> -----
> 
>   dolphin/src/kitemviews/kfileitemmodel.h dfcd879 
>   dolphin/src/kitemviews/kfileitemmodel.cpp 98249db 
>   dolphin/src/settings/general/behaviorsettingspage.h 6e49169 
>   dolphin/src/settings/general/behaviorsettingspage.cpp 83515be 
>   dolphin/src/tests/kfileitemmodelbenchmark.cpp c970a71 
> 
> Diff: https://git.reviewboard.kde.org/r/122310/diff/
> 
> 
> Testing
> -------
> 
> Works
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20150130/1684ff6c/attachment.htm>