Review Request 122310: Port Dolphin away from KGlobalSettings::naturalSorting()

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122310/
-----------------------------------------------------------

Review request for Dolphin.


Repository: kde-baseapps


Description
-------

Port away from KGlobalSettings::naturalSorting() by removing the natural-sorting option from Dolphin -> always use natural sorting

* There is no global "natural sorting" settings changed signal anymore to inform all fileitem models and all running Dolphin instances, that the natural sorting has been enabled or disabled.
* We are the only users of the natural sorting option as far as I see
* I have found no porting notes (I have found an email from Frank, where he raised the question how to port away from KGlobalSettings::naturalSorting(), but nobody answered so far)
* It would be interesting to know how many Dolphin users actually disable the natural sorting ;)

Does anybody know a better solution than always using natural sorting?


Diffs
-----

  dolphin/src/kitemviews/kfileitemmodel.h dfcd879 
  dolphin/src/kitemviews/kfileitemmodel.cpp 98249db 
  dolphin/src/settings/general/behaviorsettingspage.h 6e49169 
  dolphin/src/settings/general/behaviorsettingspage.cpp 83515be 
  dolphin/src/tests/kfileitemmodelbenchmark.cpp c970a71 

Diff: https://git.reviewboard.kde.org/r/122310/diff/


Testing
-------

Works


Thanks,

Emmanuel Pescosta

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20150129/f88b5ec6/attachment.htm>