Review Request 121478: dolphin: add menu to SpaceInfo widget for detailled disk usage information

[Gregor Mi]

> On Jan. 10, 2015, 7:51 p.m., Emmanuel Pescosta wrote:
> > dolphin/src/statusbar/statusbarspaceinfo.cpp, line 75
> > <https://git.reviewboard.kde.org/r/121478/diff/5/?file=339459#file339459line75>
> >
> >     please remove the TODO

I removed the comment. But do you have any idea about how to solve it (it is probably a general QT thing, isn't it)? (When I right-click a second time with a normal context menu it disappears instead of showing up again.)


> On Jan. 10, 2015, 7:51 p.m., Emmanuel Pescosta wrote:
> > dolphin/src/statusbar/spaceinfotoolsmenu.cpp, line 37
> > <https://git.reviewboard.kde.org/r/121478/diff/5/?file=339457#file339457line37>
> >
> >     filelight only makes sense for local urls, right? - Please check it before you add the actions

> filelight only makes sense for local urls, right?

No. I tried it with ftp://ftp-stud.fht-esslingen.de/ and ftp://ftp-stud.fht-esslingen.de/html/. This site can be displayed in dolphin and also filelight can handle FTP. But _not_ when invoked from kioexec.

Apart from that, the doc of QUrl::toLocalFile() says "... Note: if the path component of this URL contains a non-UTF-8 binary sequence (such as %80), the behaviour of this function is undefined.". I don't know if in this case isLocalFile() would be false, so checking it before calling toLocalFile seems better.

=> In two cases I made the check and added a comment.


- Gregor


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121478/#review73703
-----------------------------------------------------------


On Jan. 12, 2015, 3:20 p.m., Gregor Mi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121478/
> -----------------------------------------------------------
> 
> (Updated Jan. 12, 2015, 3:20 p.m.)
> 
> 
> Review request for Dolphin and Emmanuel Pescosta.
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> Adds a menu when left-clicked on the SpaceInfo widget in the status bar with the following entries:
> 
> (1) KDiskFree
> (2) Filelight
> (3) Filelight device
> (4) Filelight location
> 
> see screenshot: http://wstaw.org/m/2014/12/13/plasma-desktopqO2157.png
> 
> Details on the menu entries:
> 
> (1) starts KDiskFree (useful tool, hard to find when unknown by new user)
> (2) starts Filelight without parameters
> (3) starts Filelight with current mount point
> (4) starts Filelight with current location
> 
> If KDiskFree or Filelight is not installed the corresponding menu action is disabled with a hint "[Not installed]".
> 
> 
> Diffs
> -----
> 
>   dolphin/src/CMakeLists.txt f132e2844d54d08fa99b6c5ef8c5da6dfdb07514 
>   dolphin/src/statusbar/spaceinfotoolsmenu.h PRE-CREATION 
>   dolphin/src/statusbar/spaceinfotoolsmenu.cpp PRE-CREATION 
>   dolphin/src/statusbar/statusbarspaceinfo.h 5d571beba9b936c52dd3279e370c39a1bfd50827 
>   dolphin/src/statusbar/statusbarspaceinfo.cpp 046cbbb23072648aece5677defb1b9074baa9482 
> 
> Diff: https://git.reviewboard.kde.org/r/121478/diff/
> 
> 
> Testing
> -------
> 
> Clicked all the menu entries and they work as described.
> 
> 
> File Attachments
> ----------------
> 
> 2015-01-09-dolphin-diskspace.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/01/09/b87a29dc-25bc-4ce6-a5be-9fcd405fe455__2015-01-09-dolphin-diskspace.png
> 
> 
> Thanks,
> 
> Gregor Mi
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20150112/bcef5442/attachment.htm>