Review Request 121478: dolphin: add menu to SpaceInfo widget for detailled disk usage information

[Emmanuel Pescosta]

> On Jan. 4, 2015, 6:56 p.m., Emmanuel Pescosta wrote:
> > dolphin/src/statusbar/spaceinfotoolsmenu.cpp, lines 103-106
> > <https://git.reviewboard.kde.org/r/121478/diff/3/?file=334818#file334818line103>
> >
> >     Should we really show entries for not installed software? (personal opinion: no)
> 
> Gregor Mi wrote:
>     I was not sure either. My intention is to give (novice) users a hint that there are two useful KDE tools even if they are not installed. Especially in the case of low disk space I find it good to give as much support as possible. Plus, I don't like the idea so much to have a menu that does not open at all in case both programs are not installed.
>     
>     While pondering over the issue I got some questions and remarks:
>     
>     1) I could not find a list where all packages that goes into the KDE SC are listed. I remember to have seen such a list, but I could not find it. So, I wonder if KDiskFree and Filelight are part of the default installation (maybe also varies from distro to distro?).
>     
>     2) Can you give some details on why you find it better not to show the entries? I thought the following:
>     
>     2a) The two applications probably belong to the KDE standard installation. So probably most users won't see the proxy entries. And those who do get at least a hint on what to google.
>     
>     2b) I also find the solution not perfect but see it as a first step. Ideally, I would like to see something like that: "KDiskFree not installed. If you would like to install it, click here to install it", similar to /usr/bin/cnf. Among others, this would require distro specific package mgmt interaction and is out of scope this RR. Do you know if there are already approaches/discussions on the topic?

> maybe also varies from distro to distro?

Yes I assume that it varies heavily from distro to distro, but I don't know exactly.

> 2) Can you give some details on why you find it better not to show the entries? I thought the following:

I worry that people will complain about the "tool [not installed]" entries. Something like: I prefer only *some tool* and please add a configuration to remove all other *not installed* applications from this menu, because I'm absolutely not interested in other *not installed* disk utilities.

> Do you know if there are already approaches/discussions on the topic?

Sounds great but I don't no anything about this topic.


- Emmanuel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121478/#review73088
-----------------------------------------------------------


On Jan. 9, 2015, 10:29 a.m., Gregor Mi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121478/
> -----------------------------------------------------------
> 
> (Updated Jan. 9, 2015, 10:29 a.m.)
> 
> 
> Review request for Dolphin and Emmanuel Pescosta.
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> Adds a menu when left-clicked on the SpaceInfo widget in the status bar with the following entries:
> 
> (1) KDiskFree
> (2) Filelight
> (3) Filelight device
> (4) Filelight location
> 
> see screenshot: http://wstaw.org/m/2014/12/13/plasma-desktopqO2157.png
> 
> Details on the menu entries:
> 
> (1) starts KDiskFree (useful tool, hard to find when unknown by new user)
> (2) starts Filelight without parameters
> (3) starts Filelight with current mount point
> (4) starts Filelight with current location
> 
> If KDiskFree or Filelight is not installed the corresponding menu action is disabled with a hint "[Not installed]".
> 
> 
> Diffs
> -----
> 
>   dolphin/src/statusbar/spaceinfoexternaltools.h PRE-CREATION 
>   dolphin/src/statusbar/spaceinfotoolsmenu.h PRE-CREATION 
>   dolphin/src/statusbar/spaceinfotoolsmenu.cpp PRE-CREATION 
>   dolphin/src/statusbar/statusbarspaceinfo.h 5d571beba9b936c52dd3279e370c39a1bfd50827 
>   dolphin/src/statusbar/statusbarspaceinfo.cpp 046cbbb23072648aece5677defb1b9074baa9482 
>   dolphin/src/CMakeLists.txt f132e2844d54d08fa99b6c5ef8c5da6dfdb07514 
> 
> Diff: https://git.reviewboard.kde.org/r/121478/diff/
> 
> 
> Testing
> -------
> 
> Clicked all the menu entries and they work as described.
> 
> 
> File Attachments
> ----------------
> 
> 2015-01-09-dolphin-diskspace.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/01/09/b87a29dc-25bc-4ce6-a5be-9fcd405fe455__2015-01-09-dolphin-diskspace.png
> 
> 
> Thanks,
> 
> Gregor Mi
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20150109/01add1dc/attachment.htm>