Review Request 121478: dolphin: add menu to SpaceInfo widget for detailled disk usage information
Emmanuel Pescosta
emmanuelpescosta099 at gmail.com
Fri Jan 9 12:26:27 GMT 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121478/#review73578
-----------------------------------------------------------
There is an empty file in the patch: dolphin/src/statusbar/spaceinfoexternaltools.h
- Emmanuel Pescosta
On Jan. 9, 2015, 10:29 a.m., Gregor Mi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121478/
> -----------------------------------------------------------
>
> (Updated Jan. 9, 2015, 10:29 a.m.)
>
>
> Review request for Dolphin and Emmanuel Pescosta.
>
>
> Repository: kde-baseapps
>
>
> Description
> -------
>
> Adds a menu when left-clicked on the SpaceInfo widget in the status bar with the following entries:
>
> (1) KDiskFree
> (2) Filelight
> (3) Filelight device
> (4) Filelight location
>
> see screenshot: http://wstaw.org/m/2014/12/13/plasma-desktopqO2157.png
>
> Details on the menu entries:
>
> (1) starts KDiskFree (useful tool, hard to find when unknown by new user)
> (2) starts Filelight without parameters
> (3) starts Filelight with current mount point
> (4) starts Filelight with current location
>
> If KDiskFree or Filelight is not installed the corresponding menu action is disabled with a hint "[Not installed]".
>
>
> Diffs
> -----
>
> dolphin/src/statusbar/spaceinfoexternaltools.h PRE-CREATION
> dolphin/src/statusbar/spaceinfotoolsmenu.h PRE-CREATION
> dolphin/src/statusbar/spaceinfotoolsmenu.cpp PRE-CREATION
> dolphin/src/statusbar/statusbarspaceinfo.h 5d571beba9b936c52dd3279e370c39a1bfd50827
> dolphin/src/statusbar/statusbarspaceinfo.cpp 046cbbb23072648aece5677defb1b9074baa9482
> dolphin/src/CMakeLists.txt f132e2844d54d08fa99b6c5ef8c5da6dfdb07514
>
> Diff: https://git.reviewboard.kde.org/r/121478/diff/
>
>
> Testing
> -------
>
> Clicked all the menu entries and they work as described.
>
>
> File Attachments
> ----------------
>
> 2015-01-09-dolphin-diskspace.png
> https://git.reviewboard.kde.org/media/uploaded/files/2015/01/09/b87a29dc-25bc-4ce6-a5be-9fcd405fe455__2015-01-09-dolphin-diskspace.png
>
>
> Thanks,
>
> Gregor Mi
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20150109/ad9f8fb7/attachment.htm>
More information about the kfm-devel
mailing list