Review Request 121817: Fix for crash which was introduced by RR 121480 (use QCollator instead of KStringHandler)

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121817/
-----------------------------------------------------------

(Updated Jan. 4, 2015, 8:48 p.m.)


Status
------

This change has been marked as submitted.


Review request for Dolphin.


Bugs: 342316
    http://bugs.kde.org/show_bug.cgi?id=342316


Repository: kde-baseapps


Description
-------

While porting away from KStringHandler::naturalCompare to QCollator::compare, I had thought that QCollator is an drop-in replacement for KStringHanlder (also regarding to thread safety) - but according to the docs it's reentrant only (sry I missed that), surprisingly sorting with multiple threads never crashed here.

To fix the issue, we create a new thread local QCollator instance for every thread.


Diffs
-----

  dolphin/src/kitemviews/kfileitemmodel.h df7a5e3 
  dolphin/src/kitemviews/kfileitemmodel.cpp 1c92a2c 

Diff: https://git.reviewboard.kde.org/r/121817/diff/


Testing
-------

Kai and Lane tested this patch and they confirmed that the patch fixes the crash for them.


Thanks,

Emmanuel Pescosta

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20150104/820a83f5/attachment.htm>