Review Request 121478: dolphin: add menu to SpaceInfo widget for detailled disk usage information

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121478/#review73088
-----------------------------------------------------------



dolphin/src/statusbar/spaceinfotoolsmenu.h
<https://git.reviewboard.kde.org/r/121478/#comment50836>

    please inherit from QMenu



dolphin/src/statusbar/spaceinfotoolsmenu.cpp
<https://git.reviewboard.kde.org/r/121478/#comment50841>

    if (service && service->isApplication())



dolphin/src/statusbar/spaceinfotoolsmenu.cpp
<https://git.reviewboard.kde.org/r/121478/#comment50840>

    if (service && service->isApplication())



dolphin/src/statusbar/spaceinfotoolsmenu.cpp
<https://git.reviewboard.kde.org/r/121478/#comment50837>

    move the menu entry creation into the ctor



dolphin/src/statusbar/spaceinfotoolsmenu.cpp
<https://git.reviewboard.kde.org/r/121478/#comment50839>

    Should we really show entries for not installed software? (personal opinion: no)



dolphin/src/statusbar/spaceinfotoolsmenu.cpp
<https://git.reviewboard.kde.org/r/121478/#comment50838>

    Replace the action comparism by using the actions triggered signals and lambda functions.
    
    e.g.
    
    connect(startFilelightDirectoryAction, &QAction::triggered, this, [filelightService, url](bool) {
       KRun::run(*filelightService, {url.path()}, nullptr);
    });



dolphin/src/statusbar/statusbarspaceinfo.cpp
<https://git.reviewboard.kde.org/r/121478/#comment50842>

    after inheriting from QMenu, you can use exec(QCursor::pos()) here


- Emmanuel Pescosta


On Jan. 3, 2015, 12:38 a.m., Gregor Mi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121478/
> -----------------------------------------------------------
> 
> (Updated Jan. 3, 2015, 12:38 a.m.)
> 
> 
> Review request for Dolphin, David Faure, Emmanuel Pescosta, and Eike Hein.
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> Adds a menu when left-clicked on the SpaceInfo widget in the status bar with the following entries:
> 
> (1) KDiskFree
> (2) Filelight
> (3) Filelight device
> (4) Filelight location
> 
> see screenshot: http://wstaw.org/m/2014/12/13/plasma-desktopqO2157.png
> 
> Details on the menu entries:
> 
> (1) starts KDiskFree (useful tool, hard to find when unknown by new user)
> (2) starts Filelight without parameters
> (3) starts Filelight with current mount point
> (4) starts Filelight with current location
> 
> If KDiskFree or Filelight is not installed the corresponding menu action is disabled with a hint "[Not installed]".
> 
> 
> Diffs
> -----
> 
>   dolphin/src/CMakeLists.txt f132e2844d54d08fa99b6c5ef8c5da6dfdb07514 
>   dolphin/src/statusbar/spaceinfoexternaltools.h PRE-CREATION 
>   dolphin/src/statusbar/spaceinfotoolsmenu.h PRE-CREATION 
>   dolphin/src/statusbar/spaceinfotoolsmenu.cpp PRE-CREATION 
>   dolphin/src/statusbar/statusbarspaceinfo.h 5d571beba9b936c52dd3279e370c39a1bfd50827 
>   dolphin/src/statusbar/statusbarspaceinfo.cpp 046cbbb23072648aece5677defb1b9074baa9482 
> 
> Diff: https://git.reviewboard.kde.org/r/121478/diff/
> 
> 
> Testing
> -------
> 
> Clicked all the menu entries and they work as described.
> 
> 
> Thanks,
> 
> Gregor Mi
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20150104/165e219d/attachment.htm>