Review Request 121678: Dolphin: port from KonqOperations::doDrop to the new KIO::DropJob

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121678/
-----------------------------------------------------------

(Updated Jan. 2, 2015, 8:36 a.m.)


Review request for Dolphin.


Changes
-------

Fixed issues (thanks for the review!)


Repository: kde-baseapps


Description (updated)
-------

REVIEW: 121678


Diffs (updated)
-----

  dolphin/src/dolphintabwidget.cpp a0c9b9d8198269bcf9c560106332cdf0dd9b45a7 
  dolphin/src/dolphinviewcontainer.h bd4141db5a2d56e6a605247eaba4da3291664645 
  dolphin/src/dolphinviewcontainer.cpp 3954a12e6638c2abc7ab57c669e1dc1680b073a6 
  dolphin/src/panels/folders/folderspanel.cpp f56f5a1391831666555ac31c359ac02ba794998a 
  dolphin/src/panels/places/placespanel.cpp b04191f1c73fa42b8e9d1f18f698c2e6a4a4ee02 
  dolphin/src/views/dolphinview.h c054c311a360971d29ea796070dec9f3924ab1d9 
  dolphin/src/views/dolphinview.cpp cb25c6555ab2a4f3af67a762262f7868aaab687a 
  dolphin/src/views/draganddrophelper.h c4ae974b50ab5e0af5eb9dc749d383a8bdadb2fa 
  dolphin/src/views/draganddrophelper.cpp a09faa345179fbb016b67289c550650a56639614 

Diff: https://git.reviewboard.kde.org/r/121678/diff/


Testing
-------

Dropping between the views of a splitted dolphin mainwindow. Without modifiers, and with Ctrl, Shift, Ctrl+Shift.

Dropping onto a breadcrumb of the url navigator.

Dropping onto a tab.


Thanks,

David Faure

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20150102/3eab4938/attachment.htm>