Review Request 122687: Move the KVersionControlPlugin2 interface from konqlib to Dolphin

[Emmanuel Pescosta]

On Feb. 25, 2015, 1:02 a.m., Emmanuel Pescosta wrote:
> > Also excuse my ignorance, but where are those plugins implemented?
> > Are 3rd parties supposed to re-implement this? I'm guessing it's not possible to keep the plugins within the dolphin tree...?
> 
> Emmanuel Pescosta wrote:
>     > but where are those plugins implemented?
>     
>     dolphin-plugins repo
>     
>     > Are 3rd parties supposed to re-implement this?
>     
>     Yes
>     
>     > I'm guessing it's not possible to keep the plugins within the dolphin tree...?
>     
>     We can import the plugins from dolphin-plugins repo into the new dolphin repo after kde-baseapps has been splitted
> 
> Aleix Pol Gonzalez wrote:
>     If you assume these plugins will be within the Dolphin repository, then you can stop worrying about ABI breakages and you don't need to install headers (in fact, it's probably weird that dolphin installs headers, no?).

> ABI breakages

ABI breakages in the version control plugin interface shouldn't be a problem, it's a really stable interface ;)

> don't need to install headers

3rd party plugins need the headers, am I wrong?


- Emmanuel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122687/#review76573
-----------------------------------------------------------


On Feb. 25, 2015, 12:15 p.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122687/
> -----------------------------------------------------------
> 
> (Updated Feb. 25, 2015, 12:15 p.m.)
> 
> 
> Review request for Dolphin, Aleix Pol Gonzalez and David Faure.
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> Moved the KVersionControlPlugin2 interface from konqlib to Dolphin and remove the deprecated KVersionControlPlugin interface from konqlib
> 
> This removes the konqlib dependency from Dolphin -> ready to split kde-baseapps?
> 
> @apol: Can you please take a look at all the cmake changes? Thanks in advance :)
> 
> 
> Diffs
> -----
> 
>   dolphin/src/views/dolphinviewactionhandler.h bf664f7 
>   dolphin/src/views/draganddrophelper.h 0fbe3a1 
>   dolphin/src/views/renamedialog.h 7c02d1b 
>   dolphin/src/views/versioncontrol/kversioncontrolplugin.h PRE-CREATION 
>   dolphin/src/views/versioncontrol/kversioncontrolplugin.cpp PRE-CREATION 
>   dolphin/src/views/versioncontrol/updateitemstatesthread.h 92a9d59 
>   dolphin/src/views/versioncontrol/updateitemstatesthread.cpp 4f0122e 
>   dolphin/src/views/versioncontrol/versioncontrolobserver.h a43dc34 
>   dolphin/src/views/versioncontrol/versioncontrolobserver.cpp 47e3da3 
>   dolphin/src/views/viewmodecontroller.h 89f1020 
>   dolphin/src/views/viewproperties.h b9c2fa5 
>   lib/konq/src/CMakeLists.txt c6b97de 
>   lib/konq/src/kversioncontrolplugin.h b61e65f 
>   lib/konq/src/kversioncontrolplugin.cpp cfd8ce3 
>   lib/konq/src/kversioncontrolplugin2.h cc7f22b 
>   lib/konq/src/kversioncontrolplugin2.cpp debb18a 
>   dolphin/src/kitemviews/kitemlistgroupheader.h c89da50 
>   dolphin/src/kitemviews/kitemlistheader.h b361b91 
>   dolphin/src/kitemviews/kitemlistselectionmanager.h a831838 
>   dolphin/src/kitemviews/kitemliststyleoption.h 9290dc3 
>   dolphin/src/kitemviews/kitemlistview.h 8130e45 
>   dolphin/src/kitemviews/kitemlistviewaccessible.h 28b0be4 
>   dolphin/src/kitemviews/kitemlistwidget.h 723847c 
>   dolphin/src/kitemviews/kitemmodelbase.h e46d761 
>   dolphin/src/kitemviews/kstandarditem.h b1d5edf 
>   dolphin/src/kitemviews/kstandarditemlistgroupheader.h caf906d 
>   dolphin/src/kitemviews/kstandarditemlistview.h 9fc43a9 
>   dolphin/src/kitemviews/kstandarditemlistwidget.h 8e61d06 
>   dolphin/src/kitemviews/kstandarditemmodel.h 3b5f5bd 
>   dolphin/src/kitemviews/private/kbaloorolesprovider.h ef073a3 
>   dolphin/src/kitemviews/private/kfileitemclipboard.h d02fc0d 
>   dolphin/src/kitemviews/private/kfileitemmodeldirlister.h a9c8c84 
>   dolphin/src/kitemviews/private/kfileitemmodelfilter.h b26e31a 
>   dolphin/src/kitemviews/private/kitemlistheaderwidget.h 74c9ac5 
>   dolphin/src/kitemviews/private/kitemlistkeyboardsearchmanager.h 1f315da 
>   dolphin/src/kitemviews/private/kitemlistroleeditor.h 7c2b61e 
>   dolphin/src/kitemviews/private/kitemlistrubberband.h 39c7573 
>   dolphin/src/kitemviews/private/kitemlistselectiontoggle.h bd64879 
>   dolphin/src/kitemviews/private/kitemlistsizehintresolver.h 3bd2319 
>   dolphin/src/kitemviews/private/kitemlistsmoothscroller.h 963cf7b 
>   dolphin/src/kitemviews/private/kitemlistviewanimation.h ed4ec49 
>   dolphin/src/kitemviews/private/kitemlistviewlayouter.h fc82d60 
>   dolphin/src/kitemviews/private/kpixmapmodifier.h b5eec65 
>   dolphin/src/settings/viewpropertiesdialog.h 63c534b 
>   dolphin/src/tests/CMakeLists.txt 1c6c5b4 
>   dolphin/src/views/dolphinfileitemlistwidget.h 5f9cc3a 
>   dolphin/src/views/dolphinfileitemlistwidget.cpp e834543 
>   dolphin/src/views/dolphinitemlistview.h 2b16825 
>   dolphin/src/views/dolphinnewfilemenuobserver.h b9b18e2 
>   dolphin/src/views/dolphinremoteencoding.h 0351aba 
>   dolphin/src/views/dolphinview.h aa4492b 
>   dolphin/src/kitemviews/kfileitemmodel.h 8e36294 
>   dolphin/src/kitemviews/kfileitemmodelrolesupdater.h 6c82dbe 
>   dolphin/src/kitemviews/kfileitemmodelrolesupdater.cpp f17a77e 
>   dolphin/src/kitemviews/kitemlistcontainer.h 6f2851b 
>   dolphin/src/kitemviews/kitemlistcontroller.h 2824a1f 
>   dolphin/CMakeLists.txt 5709104 
>   dolphin/DolphinVcsConfig.cmake.in PRE-CREATION 
>   dolphin/src/CMakeLists.txt ea21f1a 
>   dolphin/src/dolphinnewfilemenu.h 254571e 
>   dolphin/src/dolphinremoveaction.h 1a123ac 
>   dolphin/src/kitemviews/kfileitemlistview.h 7268889 
>   dolphin/src/kitemviews/kfileitemlistwidget.h 32959e4 
> 
> Diff: https://git.reviewboard.kde.org/r/122687/diff/
> 
> 
> Testing
> -------
> 
> Dropbox plugin builds (see RR 122688)
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20150225/e183a691/attachment.htm>