Review Request 122625: Fix a QDateTime porting bug in KFileItemModel::dateRoleGroups
Frank Reininghaus
frank78ac at googlemail.com
Thu Feb 19 20:35:07 GMT 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122625/#review76311
-----------------------------------------------------------
Ship it!
Looks good :-)
- Frank Reininghaus
On Feb. 18, 2015, 12:27 nachm., Emmanuel Pescosta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122625/
> -----------------------------------------------------------
>
> (Updated Feb. 18, 2015, 12:27 nachm.)
>
>
> Review request for Dolphin.
>
>
> Repository: kde-baseapps
>
>
> Description
> -------
>
> Fix a QDateTime porting bug (different format expressions) in KFileItemModel::dateRoleGroups
>
> QDateTime::toString uses d, dd, M, MM, ... expressions instead of %B, %Y, ... expressions which are currently used in the translated strings.
>
>
> Diffs
> -----
>
> dolphin/src/kitemviews/kfileitemmodel.cpp 99edd97
>
> Diff: https://git.reviewboard.kde.org/r/122625/diff/
>
>
> Testing
> -------
>
> Grouping works.
>
>
> Thanks,
>
> Emmanuel Pescosta
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20150219/97291333/attachment.htm>
More information about the kfm-devel
mailing list