Review Request 122631: Make the FoldersPanel work again

Emmanuel Pescosta emmanuelpescosta099 at gmail.com
Thu Feb 19 11:11:27 GMT 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122631/
-----------------------------------------------------------

(Updated Feb. 19, 2015, 11:11 a.m.)


Status
------

This change has been marked as submitted.


Review request for Dolphin.


Bugs: 344204
    http://bugs.kde.org/show_bug.cgi?id=344204


Repository: kde-baseapps


Description
-------

QUrl porting bug: Added a missing QUrl::fromLocalFile in FoldersPanel::loadTree to make the FoldersPanel work again

PS: Maybe we should remove the "remove_definitions(-DQT_NO_URL_CAST_FROM_STRING)" from cmake to avoid such problems in future :/


Diffs
-----

  dolphin/src/panels/folders/folderspanel.cpp b83e950 

Diff: https://git.reviewboard.kde.org/r/122631/diff/


Testing
-------

Works, tested with local and remote locations


Thanks,

Emmanuel Pescosta

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20150219/8edaffc4/attachment.htm>


More information about the kfm-devel mailing list