Review Request 122311: Port Dolphin away from KGlobalSettings::singleClick()

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122311/
-----------------------------------------------------------

(Updated Feb. 1, 2015, 4:23 p.m.)


Review request for Dolphin.


Changes
-------

Keep the test case by "simulating" the single/double click style hint options


Repository: kde-baseapps


Description
-------

Port away from KGlobalSettings::singleClick() and use the mouse kcm module instead of implementing the single/double click settings on our one. 

I think this solution is better than copying the code from the (more advanced) mouse kcm into Dolphin. What do you think?


Diffs (updated)
-----

  dolphin/src/kitemviews/kitemlistcontroller.h ed5b716 
  dolphin/src/kitemviews/kitemlistcontroller.cpp 812d1c9 
  dolphin/src/settings/navigation/navigationsettingspage.h ff1ed31 
  dolphin/src/settings/navigation/navigationsettingspage.cpp 69feed3 
  dolphin/src/tests/kitemlistcontrollertest.cpp cd4d0a6 

Diff: https://git.reviewboard.kde.org/r/122311/diff/


Testing
-------

Changing to single/double click activation in the Mouse KCM also changes the behaviour in Dolphin


Thanks,

Emmanuel Pescosta

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20150201/36861d6f/attachment.htm>