Review Request 122305: Port Dolphin from KDialog to QDialog

[Aleix Pol Gonzalez]

> On Feb. 1, 2015, 2:41 p.m., Mark Gaiser wrote:
> > dolphin/src/settings/viewpropertiesdialog.h, line 42
> > <https://git.reviewboard.kde.org/r/122305/diff/1/?file=345675#file345675line42>
> >
> >     final? Nobody is allowed to inherit from that class?
> >     
> >     Well, it's mostly internal dolphin stuff so i don't really see a need to mark something final. Other then that, KDE supports visual studio 2010 and that has only partial support for override and final [1]. They don't really say what partial is.. Anyway, i'd remove it to be on the safe side.
> >     
> >     [1] https://msdn.microsoft.com/en-us/library/hh567368.aspx

You're thinking about KDE Frameworks. KDE itself doesn't support Visual Studio, Dolphin should decide whether to support it.


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122305/#review75137
-----------------------------------------------------------


On Jan. 29, 2015, 1:12 p.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122305/
> -----------------------------------------------------------
> 
> (Updated Jan. 29, 2015, 1:12 p.m.)
> 
> 
> Review request for Dolphin and Christoph Feck.
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> Ported Dolphin from KDialog to QDialog and save/restoreDialogSize to KWindowConfig::save/restoreWindowSize with the help of the porting scripts.
> 
> @Christoph
> I have added you to this review request, because you are the layout porting expert from what I haven seen so far ;)
> 
> 
> Diffs
> -----
> 
>   dolphin/src/settings/navigation/navigationsettingspage.cpp 69feed3 
>   dolphin/src/settings/startup/startupsettingspage.cpp 11adb86 
>   dolphin/src/dolphinmainwindow.cpp 398af70 
>   dolphin/src/panels/information/informationpanelcontent.cpp 4e32a79 
>   dolphin/src/panels/information/phononwidget.cpp 215be20 
>   dolphin/src/settings/additionalinfodialog.h 4197d47 
>   dolphin/src/settings/additionalinfodialog.cpp 4d1b69c 
>   dolphin/src/settings/general/configurepreviewplugindialog.h 02a0cde 
>   dolphin/src/settings/general/configurepreviewplugindialog.cpp eb9ad01 
>   dolphin/src/settings/general/confirmationssettingspage.cpp 617d31c 
>   dolphin/src/settings/general/generalsettingspage.cpp f32cb9c 
>   dolphin/src/settings/general/previewssettingspage.cpp 835af9d 
>   dolphin/src/settings/general/statusbarsettingspage.cpp d12a0c1 
>   dolphin/src/settings/kcm/kcmdolphingeneral.cpp 2856336 
>   dolphin/src/settings/kcm/kcmdolphinnavigation.cpp 5a0be61 
>   dolphin/src/settings/kcm/kcmdolphinservices.cpp b00f58a 
>   dolphin/src/settings/kcm/kcmdolphinviewmodes.cpp d9c8a1a 
>   dolphin/src/settings/trash/trashsettingspage.cpp aa4b5a2 
>   dolphin/src/settings/viewmodes/viewsettingspage.cpp 12d4ce0 
>   dolphin/src/settings/viewpropertiesdialog.h 6b0e9ff 
>   dolphin/src/settings/viewpropertiesdialog.cpp 2e503bb 
>   dolphin/src/settings/viewpropsprogressinfo.h 13089b7 
>   dolphin/src/settings/viewpropsprogressinfo.cpp 9ce3d2d 
> 
> Diff: https://git.reviewboard.kde.org/r/122305/diff/
> 
> 
> Testing
> -------
> 
> Compared all the dialogs with Dolphin 14.12 dialogs, the layouts are almost the same.
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20150201/71b5a175/attachment.htm>