Review Request 126527: Improved commit dialog of dolphin hg plugin

Emmanuel Pescosta emmanuelpescosta099 at gmail.com
Tue Dec 29 09:25:15 GMT 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126527/#review90268
-----------------------------------------------------------


Btw. you can add screenshots to the review directly.

- Emmanuel Pescosta


On Dec. 26, 2015, 4:30 p.m., Tomasz Bojczuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126527/
> -----------------------------------------------------------
> 
> (Updated Dec. 26, 2015, 4:30 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Repository: dolphin-plugins
> 
> 
> Description
> -------
> 
> Commit widget changed from QPlainTextEdit into KTextEditor::Document for spell i.e.
> Added two splitters for layout to adjust size of commit editor widget and width of file list widget.
> All is stored using already existing settings mechanism (added entries to kcfg)
> 
> Here are screens:
> http://nootka.sldc.pl/hg/hg-commit-old.png
> http://nootka.sldc.pl/hg/hg-commit-new.png
> 
> P.S.
> What do You think to have such a commit dialog in git?
> 
> 
> Diffs
> -----
> 
>   hg/commitdialog.h 79b903b 
>   hg/commitdialog.cpp 5aeb683 
>   hg/fileviewhgpluginsettings.kcfg d22c80b 
> 
> Diff: https://git.reviewboard.kde.org/r/126527/diff/
> 
> 
> Testing
> -------
> 
> Works fine for me. (Frankly I'm using it for a long but I was waiting for 15.12 release to push new things)
> 
> 
> Thanks,
> 
> Tomasz Bojczuk
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20151229/0d283c02/attachment.htm>


More information about the kfm-devel mailing list