Review Request 126527: Improved commit dialog of dolphin hg plugin

[Laurent Montel]

> On déc. 26, 2015, 8:44 après-midi, Laurent Montel wrote:
> > for spell checking you can use directly a ktextedit no ? it avoid to add big object as ktexteditor no ?
> 
> Tomasz Bojczuk wrote:
>     But under commit widget there was already KTextEditor::Document as diff view. (For highlight purpose)
>     Didn't use the same type cost less than include and create other one?

Ah I didn't see.
So indeed it will not make a big diff. Ok


- Laurent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126527/#review90124
-----------------------------------------------------------


On déc. 26, 2015, 3:30 après-midi, Tomasz Bojczuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126527/
> -----------------------------------------------------------
> 
> (Updated déc. 26, 2015, 3:30 après-midi)
> 
> 
> Review request for Dolphin.
> 
> 
> Repository: dolphin-plugins
> 
> 
> Description
> -------
> 
> Commit widget changed from QPlainTextEdit into KTextEditor::Document for spell i.e.
> Added two splitters for layout to adjust size of commit editor widget and width of file list widget.
> All is stored using already existing settings mechanism (added entries to kcfg)
> 
> Here are screens:
> http://nootka.sldc.pl/hg/hg-commit-old.png
> http://nootka.sldc.pl/hg/hg-commit-new.png
> 
> P.S.
> What do You think to have such a commit dialog in git?
> 
> 
> Diffs
> -----
> 
>   hg/commitdialog.h 79b903b 
>   hg/commitdialog.cpp 5aeb683 
>   hg/fileviewhgpluginsettings.kcfg d22c80b 
> 
> Diff: https://git.reviewboard.kde.org/r/126527/diff/
> 
> 
> Testing
> -------
> 
> Works fine for me. (Frankly I'm using it for a long but I was waiting for 15.12 release to push new things)
> 
> 
> Thanks,
> 
> Tomasz Bojczuk
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20151227/4ee036a1/attachment.htm>