Review Request 126526: [hg]Fixed memory leak

[Laurent Montel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126526/#review90123
-----------------------------------------------------------


Seems good for me.
I can't write "ship it" as I am not a dolphin developper but it seems ok.

- Laurent Montel


On déc. 26, 2015, 1:52 après-midi, Tomasz Bojczuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126526/
> -----------------------------------------------------------
> 
> (Updated déc. 26, 2015, 1:52 après-midi)
> 
> 
> Review request for Dolphin.
> 
> 
> Repository: dolphin-plugins
> 
> 
> Description
> -------
> 
> There is KConfig instance
> KConfig *m_config;
> It is created in constructor but never deleted (no destructor).
> Added destructor then.
> In occasion, when m_config is created - wrapped file name text by QLatin1String
> 
> 
> Diffs
> -----
> 
>   hg/config-widgets/pluginsettings.h 42d3cec 
>   hg/config-widgets/pluginsettings.cpp 2267a3a 
> 
> Diff: https://git.reviewboard.kde.org/r/126526/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Tomasz Bojczuk
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20151226/ff0f680a/attachment.htm>