Review Request 126467: Add Case Sensitive Sorting to Dolphin

[arnav dhamija]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126467/
-----------------------------------------------------------

(Updated Dec. 26, 2015, 5:45 p.m.)


Review request for Dolphin, KDE Usability and Emmanuel Pescosta.


Changes
-------

Added an Enum class for the sorting options by modifying the Dolphin settings KConfig XT file and deleted the functions it replaces.


Bugs: 148550
    https://bugs.kde.org/show_bug.cgi?id=148550


Repository: dolphin


Description
-------

See also: https://git.reviewboard.kde.org/r/112330/

This patch was redone because of the transition to KF5.

This patch adds an option for case sensitive sorting in Dolphin under General Settings by updating the Case Sensitivity of the QCollator in kfileitemmodel.cpp as with the user's selection. Much of what I have done has been based off the code for the Natural Sorting option.

However I have made a few observations of the results:
1) Toggling the Natural Sorting or the Case Sensitive Sorting checkbox in General Settings will not update the sorting of the files in a directory until Dolphin is restarted (I guess this is a bug?).
2) If Natural Sorting AND Case Sensitive Sorting are enabled together, Dolphin will sort the files in Natural Sorting using Case Insensitive mode. This is probably a bug on my part - so I would be glad to have a more experienced programmer take a look at it.

After some thinking, if Case Sensitive Sorting and Natural Sorting cannot play well together, we can reorganise the General Settings option menu as follows:

<CheckBox>Enable Extra Sorting Features
        <RadioButton>Natural Sorting
        <RadioButton>Case Sensitive Sorting
        
An example of this can be seen in the screenshot attached with this review request.

EDIT: it was suggested in the comments to use 3 radio buttons for the sorting options as all 3 are mutually exclusive. This change is reflected in the 2nd screenshot (on Unity Ubuntu 15.10)


Diffs (updated)
-----

  kitemviews/kfileitemmodel.h 167f508 
  kitemviews/kfileitemmodel.cpp 5f6fed0 
  settings/dolphin_generalsettings.kcfg 9ff14d1 
  settings/general/behaviorsettingspage.h 6e49169 
  settings/general/behaviorsettingspage.cpp 093a1f4 

Diff: https://git.reviewboard.kde.org/r/126467/diff/


Testing
-------

manual


File Attachments
----------------

Idea for Dolphin General Settings behavior tab
  https://git.reviewboard.kde.org/media/uploaded/files/2015/12/23/d8e9eab1-1c9e-4cac-84e6-11ad10c077e9__dolphin_settings.png
Screenshot from 2015-12-23 22-21-24.png
  https://git.reviewboard.kde.org/media/uploaded/files/2015/12/23/a04136b1-b7fa-45c4-a2ec-a8d8fd3e8625__Screenshot_from_2015-12-23_22-21-24.png


Thanks,

arnav dhamija

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20151226/144f5d61/attachment.htm>