[KDE Usability] Review Request 126467: Add Case Sensitive Sorting to Dolphin

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126467/#review90013
-----------------------------------------------------------



kitemviews/kfileitemmodel.h (line 185)
<https://git.reviewboard.kde.org/r/126467/#comment61684>

    This method can be converted into an anonymous namespace function. 
    And please rename it, because "update" is not really what it does.
    
    (I would use a simple ?: operator in all two places instead)
    
    PS: in our coding style "m_" is only used for member variables



settings/dolphin_generalsettings.kcfg (line 102)
<https://git.reviewboard.kde.org/r/126467/#comment61686>

    You could use int instead of bool to store the enum value directly, which would also remove the converting in other places.



settings/dolphin_generalsettings.kcfg (line 104)
<https://git.reviewboard.kde.org/r/126467/#comment61685>

    default should be false (= case insensitive)


- Emmanuel Pescosta


On Dec. 23, 2015, 6:41 p.m., arnav dhamija wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126467/
> -----------------------------------------------------------
> 
> (Updated Dec. 23, 2015, 6:41 p.m.)
> 
> 
> Review request for Dolphin, KDE Usability and Emmanuel Pescosta.
> 
> 
> Bugs: 148550
>     https://bugs.kde.org/show_bug.cgi?id=148550
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> See also: https://git.reviewboard.kde.org/r/112330/
> 
> This patch was redone because of the transition to KF5.
> 
> This patch adds an option for case sensitive sorting in Dolphin under General Settings by updating the Case Sensitivity of the QCollator in kfileitemmodel.cpp as with the user's selection. Much of what I have done has been based off the code for the Natural Sorting option.
> 
> However I have made a few observations of the results:
> 1) Toggling the Natural Sorting or the Case Sensitive Sorting checkbox in General Settings will not update the sorting of the files in a directory until Dolphin is restarted (I guess this is a bug?).
> 2) If Natural Sorting AND Case Sensitive Sorting are enabled together, Dolphin will sort the files in Natural Sorting using Case Insensitive mode. This is probably a bug on my part - so I would be glad to have a more experienced programmer take a look at it.
> 
> After some thinking, if Case Sensitive Sorting and Natural Sorting cannot play well together, we can reorganise the General Settings option menu as follows:
> 
> <CheckBox>Enable Extra Sorting Features
>         <RadioButton>Natural Sorting
>         <RadioButton>Case Sensitive Sorting
>         
> An example of this can be seen in the screenshot attached with this review request.
> 
> 
> Diffs
> -----
> 
>   kitemviews/kfileitemmodel.h 167f508 
>   kitemviews/kfileitemmodel.cpp 5f6fed0 
>   settings/dolphin_generalsettings.kcfg 9ff14d1 
>   settings/general/behaviorsettingspage.h 6e49169 
>   settings/general/behaviorsettingspage.cpp 093a1f4 
> 
> Diff: https://git.reviewboard.kde.org/r/126467/diff/
> 
> 
> Testing
> -------
> 
> manual
> 
> 
> File Attachments
> ----------------
> 
> Idea for Dolphin General Settings behavior tab
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/12/23/d8e9eab1-1c9e-4cac-84e6-11ad10c077e9__dolphin_settings.png
> 
> 
> Thanks,
> 
> arnav dhamija
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20151223/444b8857/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-usability mailing list
kde-usability at kde.org
https://mail.kde.org/mailman/listinfo/kde-usability