Review Request 126467: Add Case Sensitive Sorting to Dolphin

[arnav dhamija]

> On Dec. 22, 2015, 2:47 p.m., Kai Uwe Broulik wrote:
> > kitemviews/kfileitemmodel.h, line 467
> > <https://git.reviewboard.kde.org/r/126467/diff/1/?file=425196#file425196line467>
> >
> >     I would prefer this to be Qt::CaseSensitivity to avoid a boolean trap

I could do this, but then there would be some coding overhead as GeneralSettings::caseSensitiveSorting() returns a boolean value. The updateCaseSenitivity() function acts when the value of the GeneralSettings::caseSensitiveSorting() using the slotCaseSensitiveSortingChanged function to avoid boolean traps.


- arnav


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126467/#review89926
-----------------------------------------------------------


On Dec. 22, 2015, 12:44 p.m., arnav dhamija wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126467/
> -----------------------------------------------------------
> 
> (Updated Dec. 22, 2015, 12:44 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Bugs: https://bugs.kde.org/show_bug.cgi?id=148550
>     https://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=148550
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> See also: https://git.reviewboard.kde.org/r/112330/
> 
> This patch was redone because of the transition to KF5.
> 
> This patch adds an option for case sensitive sorting in Dolphin under General Settings by updating the Case Sensitivity of the QCollator in kfileitemmodel.cpp as with the user's selection. Much of what I have done has been based off the code for the Natural Sorting option.
> 
> However I have made a few observations of the results:
> 1) Toggling the Natural Sorting or the Case Sensitive Sorting checkbox in General Settings will not update the sorting of the files in a directory until Dolphin is restarted (I guess this is a bug?).
> 2) If Natural Sorting AND Case Sensitive Sorting are enabled together, Dolphin will sort the files in Natural Sorting using Case Insensitive mode. This is probably a bug on my part - so I would be glad to have a more experienced programmer take a look at it.
> 
> After some thinking, if Case Sensitive Sorting and Natural Sorting cannot play well together, we can reorganise the General Settings option menu as follows:
> 
> <CheckBox>Enable Extra Sorting Features
>         <RadioButton>Natural Sorting
>         <RadioButton>Case Sensitive Sorting
> 
> 
> Diffs
> -----
> 
>   dolphinviewcontainer.cpp 8fea3ba 
>   kitemviews/kfileitemmodel.h 167f508 
>   kitemviews/kfileitemmodel.cpp 5f6fed0 
>   settings/dolphin_generalsettings.kcfg 9ff14d1 
>   settings/general/behaviorsettingspage.h 6e49169 
>   settings/general/behaviorsettingspage.cpp 093a1f4 
> 
> Diff: https://git.reviewboard.kde.org/r/126467/diff/
> 
> 
> Testing
> -------
> 
> manual
> 
> 
> Thanks,
> 
> arnav dhamija
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20151223/886ad3a2/attachment.htm>