Review Request 126467: Add Case Sensitive Sorting to Dolphin

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126467/#review89926
-----------------------------------------------------------


Please also include a screenshot and add the "usability" group so they can discuss the UI.
Does this affect the File Open dialog as well?


kitemviews/kfileitemmodel.h (line 181)
<https://git.reviewboard.kde.org/r/126467/#comment61634>

    Whitespace



kitemviews/kfileitemmodel.h (line 282)
<https://git.reviewboard.kde.org/r/126467/#comment61635>

    Fix indentation



kitemviews/kfileitemmodel.h (line 283)
<https://git.reviewboard.kde.org/r/126467/#comment61636>

    Whitespace



kitemviews/kfileitemmodel.h (line 467)
<https://git.reviewboard.kde.org/r/126467/#comment61641>

    I would prefer this to be Qt::CaseSensitivity to avoid a boolean trap



kitemviews/kfileitemmodel.cpp (line 62)
<https://git.reviewboard.kde.org/r/126467/#comment61637>

    Whitespace



kitemviews/kfileitemmodel.cpp (lines 791 - 795)
<https://git.reviewboard.kde.org/r/126467/#comment61638>

    Fix indentation and add spaces:
    if (foo) {



settings/general/behaviorsettingspage.cpp (line 66)
<https://git.reviewboard.kde.org/r/126467/#comment61639>

    Whitespace



settings/general/behaviorsettingspage.cpp (lines 67 - 68)
<https://git.reviewboard.kde.org/r/126467/#comment61640>

    Fix indentation


Also perhaps add a screenshot

- Kai Uwe Broulik


On Dez. 22, 2015, 12:44 nachm., arnav dhamija wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126467/
> -----------------------------------------------------------
> 
> (Updated Dez. 22, 2015, 12:44 nachm.)
> 
> 
> Review request for Dolphin.
> 
> 
> Bugs: https://bugs.kde.org/show_bug.cgi?id=148550
>     https://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=148550
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> See also: https://git.reviewboard.kde.org/r/112330/
> 
> This patch was redone because of the transition to KF5.
> 
> This patch adds an option for case sensitive sorting in Dolphin under General Settings by updating the Case Sensitivity of the QCollator in kfileitemmodel.cpp as with the user's selection. Much of what I have done has been based off the code for the Natural Sorting option.
> 
> However I have made a few observations of the results:
> 1) Toggling the Natural Sorting or the Case Sensitive Sorting checkbox in General Settings will not update the sorting of the files in a directory until Dolphin is restarted (I guess this is a bug?).
> 2) If Natural Sorting AND Case Sensitive Sorting are enabled together, Dolphin will sort the files in Natural Sorting using Case Insensitive mode. This is probably a bug on my part - so I would be glad to have a more experienced programmer take a look at it.
> 
> After some thinking, if Case Sensitive Sorting and Natural Sorting cannot play well together, we can reorganise the General Settings option menu as follows:
> 
> <CheckBox>Enable Extra Sorting Features
>         <RadioButton>Natural Sorting
>         <RadioButton>Case Sensitive Sorting
> 
> 
> Diffs
> -----
> 
>   dolphinviewcontainer.cpp 8fea3ba 
>   kitemviews/kfileitemmodel.h 167f508 
>   kitemviews/kfileitemmodel.cpp 5f6fed0 
>   settings/dolphin_generalsettings.kcfg 9ff14d1 
>   settings/general/behaviorsettingspage.h 6e49169 
>   settings/general/behaviorsettingspage.cpp 093a1f4 
> 
> Diff: https://git.reviewboard.kde.org/r/126467/diff/
> 
> 
> Testing
> -------
> 
> manual
> 
> 
> Thanks,
> 
> arnav dhamija
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20151222/5d0fecba/attachment.htm>