Review Request 124812: do not install namelink for private library

Emmanuel Pescosta emmanuelpescosta099 at gmail.com
Wed Aug 19 18:17:59 BST 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124812/#review84059
-----------------------------------------------------------

Ship it!


Ship It!

- Emmanuel Pescosta


On Aug. 19, 2015, 10:59 a.m., Harald Sitter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124812/
> -----------------------------------------------------------
> 
> (Updated Aug. 19, 2015, 10:59 a.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> there are no headers being installed for the private library so it cannot
> be linked anyway, so we can also skip the namelink creation (.so symlink)
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 498e7c596edcd3c4d6d8793a7af49a8ca9ccd083 
> 
> Diff: https://git.reviewboard.kde.org/r/124812/diff/
> 
> 
> Testing
> -------
> 
> make && make install -> doesn't install .so symlink for private lib anymore
> 
> 
> Thanks,
> 
> Harald Sitter
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20150819/0089f857/attachment.htm>


More information about the kfm-devel mailing list