Review Request 124670: Scrolling fixes for Dolphin

[Mark Gaiser]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124670/#review83598
-----------------------------------------------------------



src/kitemviews/private/kitemlistsmoothscroller.cpp (line 175)
<https://git.reviewboard.kde.org/r/124670/#comment57855>

    The event is passed on to handleWheelEvent which in turn calls event->accept(). The Qt documentation for that states:
    "Setting the accept parameter indicates that the event receiver wants the event. Unwanted events might be propagated to the parent widget."
    
    The way i read it is that you can either accept it or return true (also accepting the event). You do both now. While that is fine, i wonder if it changes anything.


- Mark Gaiser


On aug 9, 2015, 9:52 a.m., Maxim Mikityanskiy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124670/
> -----------------------------------------------------------
> 
> (Updated aug 9, 2015, 9:52 a.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> KItemListSmoothScroller::handleWheelEvent has some issues.
> 
> At first, when I scroll file list holding mouse over the list, one mouse wheel tick corresponds to 1/4 page interval, but when I hover on QScrollBar, one wheel tick corresponds to 1 page interval.
> 
> At second, in KItemListSmoothScroller::eventFilter we don't return true, so that QScrollBar also handles this event, and total scroll interval is m_scrollBar->pageStep() + m_scrollBar->singleStep().
> 
> At third, when I use touchpad that supports smooth scrolling via XInput2, and I hover it over QScrollBar, I can only scroll content if I move my fingers very fast, because numSteps = event->delta() / 8 / 15 is just zero unless I move very fast (event->delta() in this case is less than 120).
> 
> At fourth, holding Shift while scrolling has no effect when holding mouse over QScrollBar in contrast to scrolling faster when holding mouse over file list.
> 
> The patch eliminates all these issues making the behavior of KItemListSmoothScroller the same as in KItemListContainer::wheelEvent, adding support for QWheelEvent::pixelDelta() and removing usage of deprecated QWheelEvent::delta().
> 
> 
> Diffs
> -----
> 
>   src/kitemviews/private/kitemlistsmoothscroller.cpp e70f478 
> 
> Diff: https://git.reviewboard.kde.org/r/124670/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Maxim Mikityanskiy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20150809/9989c575/attachment.htm>