Review Request 123524: Use KPropertiesDialog::showDialog(urls) in DBusInterface::ShowItemProperties

[Ashish Bansal]

> On April 27, 2015, 1:52 p.m., Ashish Bansal wrote:
> > src/dbusinterface.cpp, line 62
> > <https://git.reviewboard.kde.org/r/123524/diff/1/?file=363716#file363716line62>
> >
> >     Is this function recently been added to KPropertiesDialog? As such function has not been described in API :) 
> >     
> >     http://api.kde.org/frameworks-api/frameworks5-apidocs/kio/html/classKPropertiesDialog.html
> 
> Aleix Pol Gonzalez wrote:
>     Check the "depends on" field.
> 
> Raymond Wooninck wrote:
>     I guess this was actually a real issue as that this change is now causing the build to fail with:
>     
>      188s] /home/abuild/rpmbuild/BUILD/dolphin-15.04.60git/src/dbusinterface.cpp:62:43: error: no matching function for call to 'KPropertiesDialog::showDialog(const QList<QUrl>&)'
>     [  188s]          KPropertiesDialog::showDialog(urls);
>     [  188s]                                            ^
>     [  188s] /home/abuild/rpmbuild/BUILD/dolphin-15.04.60git/src/dbusinterface.cpp:62:43: note: candidates are:
>     [  188s] In file included from /usr/include/KF5/KIOWidgets/KPropertiesDialog:1:0,
>     [  188s]                  from /home/abuild/rpmbuild/BUILD/dolphin-15.04.60git/src/dbusinterface.cpp:26:
>     [  188s] /usr/include/KF5/KIOWidgets/kpropertiesdialog.h:168:17: note: static bool KPropertiesDialog::showDialog(const KFileItem&, QWidget*, bool)
>     [  188s]      static bool showDialog(const KFileItem &item, QWidget *parent = 0,
>     [  188s]                  ^
>     [  188s] /usr/include/KF5/KIOWidgets/kpropertiesdialog.h:168:17: note:   no known conversion for argument 1 from 'const QList<QUrl>' to 'const KFileItem&'
>     [  188s] /usr/include/KF5/KIOWidgets/kpropertiesdialog.h:179:17: note: static bool KPropertiesDialog::showDialog(const QUrl&, QWidget*, bool)
>     [  188s]      static bool showDialog(const QUrl &_url, QWidget *parent = 0,
>     [  188s]                  ^
>     [  188s] /usr/include/KF5/KIOWidgets/kpropertiesdialog.h:179:17: note:   no known conversion for argument 1 from 'const QList<QUrl>' to 'const QUrl&'
>     [  188s] /usr/include/KF5/KIOWidgets/kpropertiesdialog.h:191:17: note: static bool KPropertiesDialog::showDialog(const KFileItemList&, QWidget*, bool)
>     [  188s]      static bool showDialog(const KFileItemList &_items, QWidget *parent = 0,
>     [  188s]                  ^
>     [  188s] /usr/include/KF5/KIOWidgets/kpropertiesdialog.h:191:17: note:   no known conversion for argument 1 from 'const QList<QUrl>' to 'const KFileItemList&'

[1] has been committed recently. Installing master branch of kio would solve the problem :)

[1] https://git.reviewboard.kde.org/r/123523/


- Ashish


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123524/#review79572
-----------------------------------------------------------


On April 29, 2015, 1:43 p.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123524/
> -----------------------------------------------------------
> 
> (Updated April 29, 2015, 1:43 p.m.)
> 
> 
> Review request for Dolphin and Ashish Bansal.
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> Use KPropertiesDialog::showDialog(urls) in DBusInterface::ShowItemProperties instead of showing a new properties dialog for each url.
> 
> 
> Diffs
> -----
> 
>   src/dbusinterface.cpp b123476 
> 
> Diff: https://git.reviewboard.kde.org/r/123524/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20150429/6de2aa96/attachment.htm>