Review Request 123524: Use KPropertiesDialog::showDialog(urls) in DBusInterface::ShowItemProperties

Aleix Pol Gonzalez aleixpol at kde.org
Mon Apr 27 15:07:46 BST 2015



> On April 27, 2015, 3:52 p.m., Ashish Bansal wrote:
> > src/dbusinterface.cpp, line 62
> > <https://git.reviewboard.kde.org/r/123524/diff/1/?file=363716#file363716line62>
> >
> >     Is this function recently been added to KPropertiesDialog? As such function has not been described in API :) 
> >     
> >     http://api.kde.org/frameworks-api/frameworks5-apidocs/kio/html/classKPropertiesDialog.html

Check the "depends on" field.


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123524/#review79572
-----------------------------------------------------------


On April 27, 2015, 1:51 p.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123524/
> -----------------------------------------------------------
> 
> (Updated April 27, 2015, 1:51 p.m.)
> 
> 
> Review request for Dolphin and Ashish Bansal.
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> Use KPropertiesDialog::showDialog(urls) in DBusInterface::ShowItemProperties instead of showing a new properties dialog for each url.
> 
> 
> Diffs
> -----
> 
>   src/dbusinterface.cpp b123476 
> 
> Diff: https://git.reviewboard.kde.org/r/123524/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20150427/d10b5d1e/attachment.htm>


More information about the kfm-devel mailing list