Review Request 123313: Add Dolphin DBus interface

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123313/#review79157
-----------------------------------------------------------



CMakeLists.txt (line 127)
<https://git.reviewboard.kde.org/r/123313/#comment54094>

    Please replace it by ecm_dbus_add_activation_service if possible.
    
    http://api.kde.org/ecm/module/ECMDBusAddActivationService.html



src/dbusinterface.h (line 1)
<https://git.reviewboard.kde.org/r/123313/#comment54103>

    Please add a licence header (with your name)



src/dbusinterface.cpp (line 1)
<https://git.reviewboard.kde.org/r/123313/#comment54102>

    Please add a licence header (with your name)



src/dbusinterface.cpp (line 19)
<https://git.reviewboard.kde.org/r/123313/#comment54095>

    const



src/dbusinterface.cpp (line 29)
<https://git.reviewboard.kde.org/r/123313/#comment54096>

    const



src/dbusinterface.cpp (line 39)
<https://git.reviewboard.kde.org/r/123313/#comment54097>

    const



src/global.h (line 1)
<https://git.reviewboard.kde.org/r/123313/#comment54099>

    Please add a licence header (with your name)



src/global.h (line 7)
<https://git.reviewboard.kde.org/r/123313/#comment54098>

    move this include to global.cpp



src/global.cpp (line 1)
<https://git.reviewboard.kde.org/r/123313/#comment54100>

    Please add a licence header (with your name)



src/main.cpp (line 89)
<https://git.reviewboard.kde.org/r/123313/#comment54101>

    Dolphin should only provide the filemanager dbus interface when Dolphin is started as deamon, am I wrong?


- Emmanuel Pescosta


On April 18, 2015, 10:21 a.m., Ashish Bansal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123313/
> -----------------------------------------------------------
> 
> (Updated April 18, 2015, 10:21 a.m.)
> 
> 
> Review request for Dolphin, David Edmundson, Emmanuel Pescosta, and Eike Hein.
> 
> 
> Bugs: 343016
>     https://bugs.kde.org/show_bug.cgi?id=343016
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> Implemented org.freedesktop.FileManager1 dbus interface in dolphin
> 
> http://www.freedesktop.org/wiki/Specifications/file-manager-interface/
> 
> 
> Diffs
> -----
> 
>   src/dbusinterface.h PRE-CREATION 
>   src/CMakeLists.txt 89a4e43 
>   cmake/PkgConfigGetVar.cmake PRE-CREATION 
>   org.kde.dolphin.FileManager1.service.in PRE-CREATION 
>   cmake/DbusInterfaceMacros.cmake PRE-CREATION 
>   CMakeLists.txt daf9271 
>   src/dbusinterface.cpp PRE-CREATION 
>   src/global.h PRE-CREATION 
>   src/global.cpp PRE-CREATION 
>   src/main.cpp 1c0fdab 
> 
> Diff: https://git.reviewboard.kde.org/r/123313/diff/
> 
> 
> Testing
> -------
> 
> Works fine with dbus-send, firefox.
> But sadly does not works with chromium, probably chromium had not implemented it yet!
> 
> 
> Thanks,
> 
> Ashish Bansal
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20150418/931f1989/attachment.htm>