Review Request 123313: Add Dolphin DBus interface

[Emmanuel Pescosta]

> On April 15, 2015, 5:45 p.m., Emmanuel Pescosta wrote:
> > src/dbusinterface.cpp, line 17
> > <https://git.reviewboard.kde.org/r/123313/diff/2/?file=360714#file360714line17>
> >
> >     Sadly Dolphin isn't ready for multiple DolphinMainWindow instances in one process atm, because there are multiple singletons around which will break when multiple main windows share the same process. This is something which needs to be fixed in future.
> >     
> >     As a temporary solution you can start a new Dolphin process instead.
> 
> Emmanuel Pescosta wrote:
>     Another problem is that DolphinMainWindow::openDirectories/openFiles requires at least one url (even when the method description doesn't mention it, which is bad :/ - I'll fix it). 
>     So almost the same logic as in main.cpp will be required -> main window factory, I'll prepare a patch ;)

> So almost the same logic as in main.cpp will be required

After thinking about this again, I was wrong. 
If the dbus client doesn't pass on at least one valid url, then we shouldn't open a new main window (using the home url as fallback as in main doesn't make sense here)


- Emmanuel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123313/#review78969
-----------------------------------------------------------


On April 16, 2015, 9:49 a.m., Ashish Bansal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123313/
> -----------------------------------------------------------
> 
> (Updated April 16, 2015, 9:49 a.m.)
> 
> 
> Review request for Dolphin, David Edmundson, Emmanuel Pescosta, and Eike Hein.
> 
> 
> Bugs: 343016
>     https://bugs.kde.org/show_bug.cgi?id=343016
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> Implemented org.freedesktop.FileManager1 dbus interface in dolphin
> 
> http://www.freedesktop.org/wiki/Specifications/file-manager-interface/
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt daf9271 
>   cmake/DbusInterfaceMacros.cmake PRE-CREATION 
>   cmake/PkgConfigGetVar.cmake PRE-CREATION 
>   org.kde.dolphin.FileManager1.service.in PRE-CREATION 
>   src/CMakeLists.txt 89a4e43 
>   src/dbusinterface.h PRE-CREATION 
>   src/dbusinterface.cpp PRE-CREATION 
>   src/main.cpp 1c0fdab 
> 
> Diff: https://git.reviewboard.kde.org/r/123313/diff/
> 
> 
> Testing
> -------
> 
> Works fine with dbus-send, firefox.
> But sadly does not works with chromium, probably chromium had not implemented it yet!
> 
> 
> Thanks,
> 
> Ashish Bansal
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20150417/88474dc0/attachment.htm>