Review Request 123313: Add Dolphin DBus interface

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123313/#review79110
-----------------------------------------------------------


Please adjust your code to style: Type& foo
Thanks!


src/dbusinterface.cpp (line 11)
<https://git.reviewboard.kde.org/r/123313/#comment54064>

    missing base class initialisation



src/dbusinterface.cpp (lines 20 - 26)
<https://git.reviewboard.kde.org/r/123313/#comment54065>

    KRun::run("dolphin %u", urls, nullptr);



src/dbusinterface.cpp (lines 32 - 39)
<https://git.reviewboard.kde.org/r/123313/#comment54066>

    KRun



src/dbusinterface.cpp (line 45)
<https://git.reviewboard.kde.org/r/123313/#comment54067>

    No need to store the returned value in a const ref because almost all compilers do return value optimization and in this special case a copy ctor call would also be very cheap, because QList does copy on write internally ;)


- Emmanuel Pescosta


On April 16, 2015, 9:49 a.m., Ashish Bansal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123313/
> -----------------------------------------------------------
> 
> (Updated April 16, 2015, 9:49 a.m.)
> 
> 
> Review request for Dolphin, David Edmundson, Emmanuel Pescosta, and Eike Hein.
> 
> 
> Bugs: 343016
>     https://bugs.kde.org/show_bug.cgi?id=343016
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> Implemented org.freedesktop.FileManager1 dbus interface in dolphin
> 
> http://www.freedesktop.org/wiki/Specifications/file-manager-interface/
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt daf9271 
>   cmake/DbusInterfaceMacros.cmake PRE-CREATION 
>   cmake/PkgConfigGetVar.cmake PRE-CREATION 
>   org.kde.dolphin.FileManager1.service.in PRE-CREATION 
>   src/CMakeLists.txt 89a4e43 
>   src/dbusinterface.h PRE-CREATION 
>   src/dbusinterface.cpp PRE-CREATION 
>   src/main.cpp 1c0fdab 
> 
> Diff: https://git.reviewboard.kde.org/r/123313/diff/
> 
> 
> Testing
> -------
> 
> Works fine with dbus-send, firefox.
> But sadly does not works with chromium, probably chromium had not implemented it yet!
> 
> 
> Thanks,
> 
> Ashish Bansal
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20150417/10858edb/attachment.htm>