Review Request 123313: Add Dolphin DBus interface

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123313/#review78969
-----------------------------------------------------------



src/dbusinterface.h (lines 13 - 18)
<https://git.reviewboard.kde.org/r/123313/#comment53974>

    wrong indentation



src/dbusinterface.h (line 18)
<https://git.reviewboard.kde.org/r/123313/#comment53973>

    Coding style: QList<QUrl>



src/dbusinterface.cpp (line 17)
<https://git.reviewboard.kde.org/r/123313/#comment53975>

    Sadly Dolphin isn't ready for multiple DolphinMainWindow instances in one process atm, because there are multiple singletons around which will break when multiple main windows share the same process. This is something which needs to be fixed in future.
    
    As a temporary solution you can start a new Dolphin process instead.



src/dbusinterface.cpp (line 35)
<https://git.reviewboard.kde.org/r/123313/#comment53976>

    Coding style QList<>



src/dbusinterface.cpp (lines 37 - 39)
<https://git.reviewboard.kde.org/r/123313/#comment53978>

    KPropertiesDialog::showDialog(url)



src/dbusinterface.cpp (lines 45 - 51)
<https://git.reviewboard.kde.org/r/123313/#comment53977>

    Same code as in main.cpp, can and should be shared in future.


- Emmanuel Pescosta


On April 10, 2015, 5:18 p.m., Ashish Bansal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123313/
> -----------------------------------------------------------
> 
> (Updated April 10, 2015, 5:18 p.m.)
> 
> 
> Review request for Dolphin, David Edmundson, Emmanuel Pescosta, and Eike Hein.
> 
> 
> Bugs: 343016
>     https://bugs.kde.org/show_bug.cgi?id=343016
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> Implemented org.freedesktop.FileManager1 dbus interface in dolphin
> 
> http://www.freedesktop.org/wiki/Specifications/file-manager-interface/
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt daf9271 
>   cmake/DbusInterfaceMacros.cmake PRE-CREATION 
>   cmake/PkgConfigGetVar.cmake PRE-CREATION 
>   org.freedesktop.FileManager1.service.in PRE-CREATION 
>   src/CMakeLists.txt 89a4e43 
>   src/dbusinterface.h PRE-CREATION 
>   src/dbusinterface.cpp PRE-CREATION 
>   src/main.cpp 1c0fdab 
> 
> Diff: https://git.reviewboard.kde.org/r/123313/diff/
> 
> 
> Testing
> -------
> 
> Works fine with dbus-send, firefox.
> But sadly does not works with chromium, probably chromium had not implemented it yet!
> 
> 
> Thanks,
> 
> Ashish Bansal
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20150415/9cf9a4dd/attachment.htm>