Review Request 123313: Add Dolphin DBus interface

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123313/#review78945
-----------------------------------------------------------



src/dbusinterface.cpp (line 14)
<https://git.reviewboard.kde.org/r/123313/#comment53968>

    obvious comment, you're not doing anything with the startup ID.
    
    To explain what /should/ happen.
    
    When create a property on the X root window with:
    the property name _NET_STARTUP_INFO_BEGIN
    
    This contains the startup ID, passed here.
    
    Kwin/other window managers, can use this to pass the focus.
    
    From your side, I think you just need to call KWindowSystem::setStartupId
    
    possibly setWindowStartupId, I'm not sure.


- David Edmundson


On April 10, 2015, 3:18 p.m., Ashish Bansal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123313/
> -----------------------------------------------------------
> 
> (Updated April 10, 2015, 3:18 p.m.)
> 
> 
> Review request for Dolphin, David Edmundson, Emmanuel Pescosta, and Eike Hein.
> 
> 
> Bugs: 343016
>     https://bugs.kde.org/show_bug.cgi?id=343016
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> Implemented org.freedesktop.FileManager1 dbus interface in dolphin
> 
> http://www.freedesktop.org/wiki/Specifications/file-manager-interface/
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt daf9271 
>   cmake/DbusInterfaceMacros.cmake PRE-CREATION 
>   cmake/PkgConfigGetVar.cmake PRE-CREATION 
>   org.freedesktop.FileManager1.service.in PRE-CREATION 
>   src/CMakeLists.txt 89a4e43 
>   src/dbusinterface.h PRE-CREATION 
>   src/dbusinterface.cpp PRE-CREATION 
>   src/main.cpp 1c0fdab 
> 
> Diff: https://git.reviewboard.kde.org/r/123313/diff/
> 
> 
> Testing
> -------
> 
> Works fine with dbus-send, firefox.
> But sadly does not works with chromium, probably chromium had not implemented it yet!
> 
> 
> Thanks,
> 
> Ashish Bansal
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20150414/45e2047e/attachment.htm>