Review Request 123313: Add Dolphin DBus interface

[David Edmundson]

> On April 10, 2015, 11:55 a.m., David Edmundson wrote:
> > src/main.cpp, line 99
> > <https://git.reviewboard.kde.org/r/123313/diff/1/?file=360597#file360597line99>
> >
> >     this isn't required.
> >     
> >     There's something called DBus activation.
> >     
> >     We install a .service file into /usr/share/dbus-1/services
> >     
> >     with contents like
> >     
> >     [D-BUS Service]
> >     Name=org.freedesktop.fileManager
> >     Exec=/usr/bin/dolphin
> >     
> >     whenever a request is made on that service, your app is started, and then gets sent the request that started it.
> 
> Ashish Bansal wrote:
>     Actually the problem is when /usr/bin/dolphin would be started, it would show up dolphin main window with home directory. I have added that .service file but with Exec=/usr/bin/dolphin --daemon. So, now dolphin doesn't show up with main window whenever it has been started up by dbus activation. That's why I have added parser for "daemon".

aha! that makes sense.

And it still quits when there are no windows?


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123313/#review78760
-----------------------------------------------------------


On April 10, 2015, 3:18 p.m., Ashish Bansal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123313/
> -----------------------------------------------------------
> 
> (Updated April 10, 2015, 3:18 p.m.)
> 
> 
> Review request for Dolphin, David Edmundson, Emmanuel Pescosta, and Eike Hein.
> 
> 
> Bugs: 343016
>     https://bugs.kde.org/show_bug.cgi?id=343016
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> Implemented org.freedesktop.FileManager1 dbus interface in dolphin
> 
> http://www.freedesktop.org/wiki/Specifications/file-manager-interface/
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt daf9271 
>   cmake/DbusInterfaceMacros.cmake PRE-CREATION 
>   cmake/PkgConfigGetVar.cmake PRE-CREATION 
>   org.freedesktop.FileManager1.service.in PRE-CREATION 
>   src/CMakeLists.txt 89a4e43 
>   src/dbusinterface.h PRE-CREATION 
>   src/dbusinterface.cpp PRE-CREATION 
>   src/main.cpp 1c0fdab 
> 
> Diff: https://git.reviewboard.kde.org/r/123313/diff/
> 
> 
> Testing
> -------
> 
> Works fine with dbus-send, firefox.
> But sadly does not works with chromium, probably chromium had not implemented it yet!
> 
> 
> Thanks,
> 
> Ashish Bansal
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20150410/5b0a80ad/attachment.htm>