Review Request 123313: Add Dolphin DBus interface

Ashish Bansal bansal.ashish096 at gmail.com
Fri Apr 10 16:18:12 BST 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123313/
-----------------------------------------------------------

(Updated April 10, 2015, 3:18 p.m.)


Review request for Dolphin, David Edmundson, Emmanuel Pescosta, and Eike Hein.


Changes
-------

Fixed issues, updated description


Bugs: 343016
    https://bugs.kde.org/show_bug.cgi?id=343016


Repository: dolphin


Description (updated)
-------

Implemented org.freedesktop.FileManager1 dbus interface in dolphin

http://www.freedesktop.org/wiki/Specifications/file-manager-interface/


Diffs (updated)
-----

  CMakeLists.txt daf9271 
  cmake/DbusInterfaceMacros.cmake PRE-CREATION 
  cmake/PkgConfigGetVar.cmake PRE-CREATION 
  org.freedesktop.FileManager1.service.in PRE-CREATION 
  src/CMakeLists.txt 89a4e43 
  src/dbusinterface.h PRE-CREATION 
  src/dbusinterface.cpp PRE-CREATION 
  src/main.cpp 1c0fdab 

Diff: https://git.reviewboard.kde.org/r/123313/diff/


Testing
-------

Works fine with dbus-send, firefox.
But sadly does not works with chromium, probably chromium had not implemented it yet!


Thanks,

Ashish Bansal

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20150410/70fc64ea/attachment.htm>


More information about the kfm-devel mailing list