Review Request 123313: Add Dolphin DBus interface

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123313/#review78760
-----------------------------------------------------------



src/main.cpp (line 88)
<https://git.reviewboard.kde.org/r/123313/#comment53895>

    leaks
    
    put it on the stack, or make app the parent.



src/main.cpp (line 99)
<https://git.reviewboard.kde.org/r/123313/#comment53894>

    this isn't required.
    
    There's something called DBus activation.
    
    We install a .service file into /usr/share/dbus-1/services
    
    with contents like
    
    [D-BUS Service]
    Name=org.freedesktop.fileManager
    Exec=/usr/bin/dolphin
    
    whenever a request is made on that service, your app is started, and then gets sent the request that started it.


- David Edmundson


On April 10, 2015, 4:29 a.m., Ashish Bansal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123313/
> -----------------------------------------------------------
> 
> (Updated April 10, 2015, 4:29 a.m.)
> 
> 
> Review request for Dolphin, David Edmundson, Emmanuel Pescosta, and Eike Hein.
> 
> 
> Bugs: 343016
>     https://bugs.kde.org/show_bug.cgi?id=343016
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> Implemented org.freedesktop.FileManager1 dbus interface in dolphin
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt daf9271 
>   cmake/DbusInterfaceMacros.cmake PRE-CREATION 
>   cmake/PkgConfigGetVar.cmake PRE-CREATION 
>   org.freedesktop.FileManager1.service.in PRE-CREATION 
>   src/CMakeLists.txt 89a4e43 
>   src/dbusinterface.h PRE-CREATION 
>   src/dbusinterface.cpp PRE-CREATION 
>   src/main.cpp 1c0fdab 
> 
> Diff: https://git.reviewboard.kde.org/r/123313/diff/
> 
> 
> Testing
> -------
> 
> Works fine with dbus-send, firefox.
> But sadly does not works with chromium, probably chromium had not implemented it yet!
> 
> 
> Thanks,
> 
> Ashish Bansal
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20150410/b67ad8e2/attachment.htm>