Review Request 123313: Add Dolphin DBus interface

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123313/#review78753
-----------------------------------------------------------


A couple of coding nitpicks below


src/dbusinterface.h (lines 5 - 6)
<https://git.reviewboard.kde.org/r/123313/#comment53884>

    Forward declare, once you pass them by reference. Also QList and QUrl includes missing



src/dbusinterface.h (lines 15 - 17)
<https://git.reviewboard.kde.org/r/123313/#comment53883>

    Pass by const reference, const QStringList &uriList



src/dbusinterface.h (line 18)
<https://git.reviewboard.kde.org/r/123313/#comment53882>

    QList<QUrl>, also make method const



src/dbusinterface.cpp (line 32)
<https://git.reviewboard.kde.org/r/123313/#comment53886>

    const QString &, otherwise you cause the QString to detach resulting in a needless copy



src/dbusinterface.cpp (line 33)
<https://git.reviewboard.kde.org/r/123313/#comment53887>

    const



src/dbusinterface.cpp (line 34)
<https://git.reviewboard.kde.org/r/123313/#comment53889>

    Check url isValid() before spwaning the dialog



src/dbusinterface.cpp (line 36)
<https://git.reviewboard.kde.org/r/123313/#comment53888>

    Do we really want to spawn multiple property dialogs?



src/main.cpp (line 105)
<https://git.reviewboard.kde.org/r/123313/#comment53890>

    Heh, could we theoretically use that daemon to re-introduce the decade old feature of "preloading the file manager"? I think there were plans of making Dolphin a unique application again, and since now a Dolphin instance is running now..? :)


- Kai Uwe Broulik


On April 10, 2015, 4:29 vorm., Ashish Bansal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123313/
> -----------------------------------------------------------
> 
> (Updated April 10, 2015, 4:29 vorm.)
> 
> 
> Review request for Dolphin, David Edmundson, Emmanuel Pescosta, and Eike Hein.
> 
> 
> Bugs: 343016
>     https://bugs.kde.org/show_bug.cgi?id=343016
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> Implemented org.freedesktop.FileManager1 dbus interface in dolphin
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt daf9271 
>   cmake/DbusInterfaceMacros.cmake PRE-CREATION 
>   cmake/PkgConfigGetVar.cmake PRE-CREATION 
>   org.freedesktop.FileManager1.service.in PRE-CREATION 
>   src/CMakeLists.txt 89a4e43 
>   src/dbusinterface.h PRE-CREATION 
>   src/dbusinterface.cpp PRE-CREATION 
>   src/main.cpp 1c0fdab 
> 
> Diff: https://git.reviewboard.kde.org/r/123313/diff/
> 
> 
> Testing
> -------
> 
> Works fine with dbus-send, firefox.
> But sadly does not works with chromium, probably chromium had not implemented it yet!
> 
> 
> Thanks,
> 
> Ashish Bansal
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20150410/14ee4490/attachment.htm>