Review Request 123278: Enable translation scripting for date groups

Lasse Liehu lasse.liehu at gmail.com
Tue Apr 7 11:38:03 BST 2015



> On huhti 7, 2015, 9:41 ap, Kai Uwe Broulik wrote:
> > Isn't there a capitalized or title date thing in QLocale?

You could use the standalone names, but they cannot be used in format strings. Also how would using standalone names affect localization to other languages? This isn't just pure enumeration of month or day of the week names, after all. Though standalone names could work well for a lot of languages because these formats consist of only the day of the week, only month and year or day of the week + month + year, without the day of month.

When using standalone month names you have https://bugreports.qt.io/browse/QTBUG-35100. Because of that month names in Plasma's calendar view are currently always capitalized for all languages: https://commits.kde.org/plasma-framework/6240b9e7 and earlier https://commits.kde.org/plasma-framework/d1dc3113?. It could be preferable to force capitalization in the same way here as well, but I don't know if that is valid for all languages. Although it could be assumed valid until someone files a bug.


- Lasse


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123278/#review78603
-----------------------------------------------------------


On huhti 6, 2015, 4:34 ip, Lasse Liehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123278/
> -----------------------------------------------------------
> 
> (Updated huhti 6, 2015, 4:34 ip)
> 
> 
> Review request for Dolphin.
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> This allows to work around limitations in Qt's date formatting.
> 
> Examples:
> 
> * Uppercasing the first character in a string because it's a title: Weekday and month names returned by QDateTime::toString are usually lowercase.
> * Correcting the noun case of a month name from "of [month]" to "in [month]" in Finnish: "of [month]" is correct when talking about a specific day, but wrong when talking about a specific month.
> 
> 
> Diffs
> -----
> 
>   src/kitemviews/kfileitemmodel.cpp eac3ddf 
> 
> Diff: https://git.reviewboard.kde.org/r/123278/diff/
> 
> 
> Testing
> -------
> 
> Checked that grouping by date still worked.
> 
> 
> Thanks,
> 
> Lasse Liehu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20150407/4c89a472/attachment.htm>


More information about the kfm-devel mailing list