Review Request 123253: dolphin: Navigate to parent folder selects child folder
Gregor Mi
codestruct at posteo.org
Sat Apr 4 14:14:29 BST 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123253/#review78483
-----------------------------------------------------------
src/dolphinviewcontainer.cpp (lines 577 - 580)
<https://git.reviewboard.kde.org/r/123253/#comment53688>
In my current default theme the "current" item is not distinguishable from any other item.
So this also marks the item as selected.
- Gregor Mi
On April 4, 2015, 1:05 p.m., Gregor Mi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123253/
> -----------------------------------------------------------
>
> (Updated April 4, 2015, 1:05 p.m.)
>
>
> Review request for Dolphin and Emmanuel Pescosta.
>
>
> Repository: dolphin
>
>
> Description
> -------
>
> first working impl
>
>
> Diffs
> -----
>
> src/dolphinviewcontainer.h 62f91100e9e5d457edd6f4d927c87610335834d7
> src/dolphinviewcontainer.cpp 8fea3ba9d0bb8389d89724b9f0cd74605c0286fe
> src/tests/kfileitemmodeltest.cpp eba32e1e1caa341e1db26399b4027a86614309fc
> src/urlutil.h PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/123253/diff/
>
>
> Testing
> -------
>
> This is a first working implementation of the feature suggestion filed in the ticket https://bugs.kde.org/show_bug.cgi?id=335616: "Dolphin: Navigate to parent folder selects child folder".
>
> In short, this is what is does: Whenever the dolphin view is initialized to show the contents of a new URL (e.g. "/home/x/test") it will be checked if the new URL is a parent of the previous displayed URL (e.g. "/home/x/test/documents/aaa"). If the check is successful, then the common child (in this example: "/home/x/test/documents/") folder item will be selected and scrolled into view.
>
>
> Thanks,
>
> Gregor Mi
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20150404/15be9ff2/attachment.htm>
More information about the kfm-devel
mailing list