Review Request 120124: ownCloud plugin for Dolphin

[Olivier Goffart]

> On Sept. 12, 2014, 2:08 p.m., Olivier Goffart wrote:
> > The protocol used by the owncloud sync client is not yet set in stone.  It is going to actually change as we are going to write the port number in the extended file attributes of the database.
> > 
> > KVersionControlPlugin2 is limited. In owncloud, we really would like to show the syncing state. 
> > Which is why i have developped an interface for having generic overlay icons:  http://lists.kde.org/?l=kfm-devel&m=140561974628961&w=2
> 
> Emmanuel Pescosta wrote:
>     > KVersionControlPlugin2 is limited.
>     
>     We can extend it ;)
>     
>     > Which is why i have developped an interface for having generic overlay icons
>     
>     I would prefer to extend the KVersionControlPlugin2. We can add a flag to
>     indicate that a file/folder has been shared.

Does a shared flag really make sens in KVersionControlPlugin?
This is a bit limited to owncloud.

I believe a more generic interface might be worth, but I could also extend KVersionControlPlugin2


- Olivier


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120124/#review66347
-----------------------------------------------------------


On Sept. 9, 2014, 10:07 p.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120124/
> -----------------------------------------------------------
> 
> (Updated Sept. 9, 2014, 10:07 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Repository: dolphin-plugins
> 
> 
> Description
> -------
> 
> I have implemented an ownCloud plugin for Dolphin based on KVersionControlPlugin2.
> 
> It is mainly a copy and paste of the Dropbox plugin with some ownCloud related protocol adjustments.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt b400ef5 
>   owncloud/CMakeLists.txt PRE-CREATION 
>   owncloud/fileviewowncloudplugin.cpp PRE-CREATION 
>   owncloud/fileviewowncloudplugin.desktop PRE-CREATION 
>   owncloud/fileviewowncloudplugin.h PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/120124/diff/
> 
> 
> Testing
> -------
> 
> Works fine for me.
> 
> Tested it with the latest ownCloud client build from master.
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20140924/19437a32/attachment.htm>