Review Request 119399: Dont show context menu when dragging and dropping onto read only folders in the places menu

David Faure faure at kde.org
Mon Sep 22 21:57:35 BST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119399/#review67236
-----------------------------------------------------------


Can't see the relation to libkonq, this patch is entirely for Dolphin :-)

Look good to me, but I'll let the dolphin maintainer decide what the best GUI is.


dolphin/src/views/draganddrophelper.cpp
<https://git.reviewboard.kde.org/r/119399/#comment46916>

    path() --> toLocalFile()


- David Faure


On July 29, 2014, 7:27 a.m., Arjun AK wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119399/
> -----------------------------------------------------------
> 
> (Updated July 29, 2014, 7:27 a.m.)
> 
> 
> Review request for Dolphin and David Faure.
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> ^
> 
> 
> Diffs
> -----
> 
>   dolphin/src/dolphinmainwindow.cpp d321d3b 
>   dolphin/src/panels/places/placespanel.h 16112e8 
>   dolphin/src/panels/places/placespanel.cpp f19fa1e 
>   dolphin/src/views/draganddrophelper.cpp f8ae0ad 
> 
> Diff: https://git.reviewboard.kde.org/r/119399/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Arjun AK
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20140922/3bba91f4/attachment.htm>


More information about the kfm-devel mailing list