Review Request 120286: Do not allow files inside trash to be added to the places panel
Emmanuel Pescosta
emmanuelpescosta099 at gmail.com
Sat Sep 20 10:23:23 BST 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120286/#review67031
-----------------------------------------------------------
Ship it!
Thanks for working on this!
Looks good and ignoring trashed items makes sense.
Please go ahead and push it to KDE/4.14 (fixed in 4.14.2)
(Please add the bug id to this review request)
dolphin/src/panels/places/placesitemmodel.cpp
<https://git.reviewboard.kde.org/r/120286/#comment46772>
Please adjust this comment.
- Emmanuel Pescosta
On Sept. 19, 2014, 6:44 p.m., Arjun AK wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120286/
> -----------------------------------------------------------
>
> (Updated Sept. 19, 2014, 6:44 p.m.)
>
>
> Review request for Dolphin.
>
>
> Repository: kde-baseapps
>
>
> Description
> -------
>
> ^
>
>
> Diffs
> -----
>
> dolphin/src/panels/places/placesitemmodel.cpp 1f05e07
>
> Diff: https://git.reviewboard.kde.org/r/120286/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Arjun AK
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20140920/bccf268e/attachment.htm>
More information about the kfm-devel
mailing list