Review Request 120171: Add option to allow execution as well as opening of scripts and desktop files

[Heiko Tietze]

> On Sept. 16, 2014, 6:51 nachm., Emmanuel Pescosta wrote:
> > dolphin/src/settings/general/behaviorsettingspage.cpp, lines 63-69
> > <https://git.reviewboard.kde.org/r/120171/diff/5/?file=312489#file312489line63>
> >
> >     @usability team:
> >     What do you think about the label and radio buttons text?
> >     
> >     e.g. Nautilus has the following settings:
> >     Executable Text Files
> >     (*) Run executable text files when they are opened
> >     ( ) View executable text files when they are opened
> >     ( ) Ask each time

Why don't you call the 'executable text file' just a script? That fits better the non-Linux variants, as a side-effect. And since options are subordinate you can shorten the caption a little bit: 

Behavior for scripts on opening
(x) Execute/Run
( ) View/Edit
( ) Always ask

Alternatively, you can apply a dropdown and have something like
[Execute] scripts on opening


- Heiko


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120171/#review66709
-----------------------------------------------------------


On Sept. 15, 2014, 10:12 nachm., Arjun Ak wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120171/
> -----------------------------------------------------------
> 
> (Updated Sept. 15, 2014, 10:12 nachm.)
> 
> 
> Review request for Dolphin, KDE Usability and David Faure.
> 
> 
> Bugs: 275405
>     http://bugs.kde.org/show_bug.cgi?id=275405
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> This patch allows the user to execute (in background, within the embedded terminal, external terminal) or open an executable file (scripts, desktop files...). When the user clicks on an executable file, a [dialog](https://git.reviewboard.kde.org/media/uploaded/files/2014/09/12/0fa53887-666f-4121-9ec6-9f323d633d03__dialog.png) pops up which contains options to either open it or execute it. Clicking on execute runs the program in the background (dolphin's current behaviour).
> 
> The [settings dialog](https://git.reviewboard.kde.org/media/uploaded/files/2014/09/12/cd4d14d3-dd82-4c2c-8c0a-c2a428c78903__settings.png) has further options to fine-tune how the file is executed. The program can either be executed in the background or inside the embedded konsole or in an external terminal.
> 
> In case there is a process already running in the embedded terminal, with [user's permission](https://git.reviewboard.kde.org/media/uploaded/files/2014/09/12/c5d7843a-099a-43d4-a2e1-6ce429623866__replace.png) it will be terminated and the selected program will be started.
> 
> 
> See also:
> https://git.reviewboard.kde.org/r/118939/
> 
> 
> Diffs
> -----
> 
>   dolphin/src/views/executablefileopendialog.cpp PRE-CREATION 
>   dolphin/src/dolphinviewcontainer.cpp a11ba42 
>   dolphin/src/settings/dolphin_generalsettings.kcfg 849a9c7 
>   dolphin/src/settings/general/behaviorsettingspage.h 7a9c2f0 
>   dolphin/src/settings/general/behaviorsettingspage.cpp cbbde1d 
>   dolphin/src/views/executablefileopendialog.h PRE-CREATION 
>   dolphin/src/CMakeLists.txt 6f256a2 
>   dolphin/src/dolphinmainwindow.h 9d4c003 
>   dolphin/src/dolphinmainwindow.cpp 95b08af 
>   dolphin/src/dolphinviewcontainer.h 31612f1 
> 
> Diff: https://git.reviewboard.kde.org/r/120171/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> Dialog
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/09/12/0fa53887-666f-4121-9ec6-9f323d633d03__dialog.png
> settings
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/09/12/cd4d14d3-dd82-4c2c-8c0a-c2a428c78903__settings.png
> Replace current program
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/09/12/c5d7843a-099a-43d4-a2e1-6ce429623866__replace.png
> 
> 
> Thanks,
> 
> Arjun Ak
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20140916/f9c1e465/attachment.htm>